forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 7
fix: staking cache to in-memory KV store #1733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
randy-cro
merged 66 commits into
crypto-org-chain:release/v0.50-cronosv1.6.x
from
randy-cro:fix/staking-optimization
Nov 21, 2025
Merged
fix: staking cache to in-memory KV store #1733
randy-cro
merged 66 commits into
crypto-org-chain:release/v0.50-cronosv1.6.x
from
randy-cro:fix/staking-optimization
Nov 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69b8ae9 to
88156ba
Compare
1138a19 to
ee6dd4c
Compare
ee6dd4c to
9bc6b87
Compare
9bc6b87 to
294f89e
Compare
JayT106
reviewed
Nov 7, 2025
JayT106
reviewed
Nov 7, 2025
JayT106
reviewed
Nov 7, 2025
JayT106
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the log info and level should be refined and simplified, more of it should put it into debug level. Some logs are using error level which the code section doesn't handle the error case.
294f89e to
266b797
Compare
4cc9190 to
1d656b1
Compare
songgaoye
reviewed
Nov 10, 2025
This comment was marked as resolved.
This comment was marked as resolved.
songgaoye
reviewed
Nov 10, 2025
Author
@songgaoye it is here, did u miss it? |
a93f620 to
b2f35a8
Compare
thomas-nguy
reviewed
Nov 20, 2025
thomas-nguy
reviewed
Nov 20, 2025
thomas-nguy
reviewed
Nov 20, 2025
thomas-nguy
reviewed
Nov 20, 2025
thomas-nguy
reviewed
Nov 20, 2025
thomas-nguy
reviewed
Nov 20, 2025
…ly set isFull as false
…ngth hits the max already
2f4f4e7 to
4071f13
Compare
thomas-nguy
reviewed
Nov 21, 2025
thomas-nguy
reviewed
Nov 21, 2025
thomas-nguy
reviewed
Nov 21, 2025
7f16a31 to
a233eac
Compare
…e and returns error when another new entry is added after the cache is full + cache error should be dirty not full
a233eac to
2cc54ab
Compare
thomas-nguy
approved these changes
Nov 21, 2025
d5e74b9
into
crypto-org-chain:release/v0.50-cronosv1.6.x
45 of 48 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Description
This PR fixes inconsistencies in the staking cache (originally implemented in PR #1725) across different nodes.
Previously, simulation or optimistic execution contexts did not properly handle discarded changes, which could lead to duplicate or incorrect cache data, eventually causing apphash mismatches and halting the chain.
The primary change refactors the cache to use an in-memory KV store.
With this approach, when a context is discarded, the cache is automatically rolled back, just like any other store in the system.
This ensures that cache state remains consistent with the underlying store, even during simulations or optimistic execution scenarios.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change