sync with upstream release/v0.47.x #418
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -379,7 +379,7 @@ | |||
| &group.EventProposalPruned{ | |||
| ProposalId: proposal.Id, | |||
| Status: proposal.Status, | |||
| TallyResult: &proposal.FinalTallyResult, | |||
| TallyResult: &proposal.FinalTallyResult, //nolint: gosec | |||
Check failure
Code scanning / Golang security checks by gosec
Implicit memory aliasing in for loop. Error
| @@ -774,7 +782,7 @@ | |||
| continue | |||
| } | |||
|
|
|||
| if err := os.WriteFile(dir+"/keyhash", passwordHash, 0o555); err != nil { | |||
| if err := os.WriteFile(dir+"/keyhash", passwordHash, 0o555); err != nil { //nolint: gosec | |||
Check failure
Code scanning / Golang security checks by gosec
Expect WriteFile permissions to be 0600 or less Error
Co-authored-by: mmsqe <mavis@crypto.com> Signed-off-by: yihuang <huang@crypto.com>
| bufHdr.Cap = sHdr.Len | ||
| bufHdr.Len = sHdr.Len | ||
| return buf | ||
| return unsafe.Slice(unsafe.StringData(s), len(s)) // ref https://github.com/golang/go/issues/53003#issuecomment-1140276077 |
Check warning
Code scanning / Golang security checks by gosec
Use of unsafe calls should be audited Warning
| bufHdr.Cap = sHdr.Len | ||
| bufHdr.Len = sHdr.Len | ||
| return buf | ||
| return unsafe.Slice(unsafe.StringData(s), len(s)) // ref https://github.com/golang/go/issues/53003#issuecomment-1140276077 |
Check warning
Code scanning / Golang security checks by gosec
Use of unsafe calls should be audited Warning
yihuang
merged commit d00edcb
into
crypto-org-chain:release/v0.47.x
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...