-
Notifications
You must be signed in to change notification settings - Fork 235
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Problem: The unlucky transactions are not shown in json rpc
Closes: #455 - add patch-tx-result command - test in integration test
- Loading branch information
Showing
10 changed files
with
345 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,264 @@ | ||
| package cmd | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "path/filepath" | ||
| "strconv" | ||
|
|
||
| "github.com/spf13/cobra" | ||
|
|
||
| "github.com/cosmos/cosmos-sdk/client" | ||
| "github.com/cosmos/cosmos-sdk/server" | ||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| abci "github.com/tendermint/tendermint/abci/types" | ||
| tmcfg "github.com/tendermint/tendermint/config" | ||
| "github.com/tendermint/tendermint/libs/log" | ||
| tmnode "github.com/tendermint/tendermint/node" | ||
| tmstate "github.com/tendermint/tendermint/proto/tendermint/state" | ||
| sm "github.com/tendermint/tendermint/state" | ||
| "github.com/tendermint/tendermint/state/txindex" | ||
| "github.com/tendermint/tendermint/state/txindex/kv" | ||
| tmstore "github.com/tendermint/tendermint/store" | ||
| tmtypes "github.com/tendermint/tendermint/types" | ||
| dbm "github.com/tendermint/tm-db" | ||
| evmtypes "github.com/tharsis/ethermint/x/evm/types" | ||
|
|
||
| "github.com/crypto-org-chain/cronos/app" | ||
| "github.com/crypto-org-chain/cronos/x/cronos/rpc" | ||
| ) | ||
|
|
||
| // FixUnluckyTxCmd update the tx execution result of false-failed tx in tendermint db | ||
| func FixUnluckyTxCmd() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "fix-unlucky-tx [start-block] [end-block]", | ||
| Short: "Fix tx execution result of false-failed tx", | ||
| Args: cobra.ExactArgs(2), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| startHeight, err := strconv.ParseInt(args[0], 10, 64) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if startHeight < 1 { | ||
| return fmt.Errorf("invalid block start-block: %d", startHeight) | ||
| } | ||
| endHeight, err := strconv.ParseInt(args[1], 10, 64) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if endHeight < startHeight { | ||
| return fmt.Errorf("invalid end-block %d, smaller than start-block", endHeight) | ||
| } | ||
|
|
||
| ctx := server.GetServerContextFromCmd(cmd) | ||
| clientCtx := client.GetClientContextFromCmd(cmd) | ||
|
|
||
| tmDB, err := openTMDB(ctx.Config) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| state, err := tmDB.stateStore.Load() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| db, err := openAppDB(ctx.Config.RootDir) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer func() { | ||
| if err := db.Close(); err != nil { | ||
| ctx.Logger.With("error", err).Error("error closing db") | ||
| } | ||
| }() | ||
|
|
||
| encCfg := app.MakeEncodingConfig() | ||
|
|
||
| anApp := app.New( | ||
| log.NewNopLogger(), db, nil, false, nil, | ||
| ctx.Config.RootDir, 0, encCfg, ctx.Viper, | ||
| ) | ||
|
|
||
| for height := startHeight; height <= endHeight; height++ { | ||
| blockResult, err := tmDB.stateStore.LoadABCIResponses(height) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| txIndex := findUnluckyTx(blockResult) | ||
| if txIndex < 0 { | ||
| // no unlucky tx in the block | ||
| continue | ||
| } | ||
|
|
||
| result, err := tmDB.replayTx(anApp, height, txIndex, state.InitialHeight) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if err := tmDB.patchDB(blockResult, result); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // decode the tx to get eth tx hashes to log | ||
| tx, err := clientCtx.TxConfig.TxDecoder()(result.Tx) | ||
| if err != nil { | ||
| fmt.Println("can't parse the patched tx", result.Height, result.Index) | ||
| } | ||
| for _, msg := range tx.GetMsgs() { | ||
| ethMsg, ok := msg.(*evmtypes.MsgEthereumTx) | ||
| if ok { | ||
| fmt.Println("patched", ethMsg.Hash, result.Height, result.Index) | ||
| } | ||
| } | ||
| } | ||
| return nil | ||
| }, | ||
| } | ||
|
|
||
| return cmd | ||
| } | ||
|
|
||
| func openAppDB(rootDir string) (dbm.DB, error) { | ||
| dataDir := filepath.Join(rootDir, "data") | ||
| return sdk.NewLevelDB("application", dataDir) | ||
| } | ||
|
|
||
| type tmDB struct { | ||
| blockStore *tmstore.BlockStore | ||
| stateStore sm.Store | ||
| txIndexer txindex.TxIndexer | ||
| } | ||
|
|
||
| func openTMDB(cfg *tmcfg.Config) (*tmDB, error) { | ||
| // open tendermint db | ||
| tmdb, err := tmnode.DefaultDBProvider(&tmnode.DBContext{ID: "blockstore", Config: cfg}) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| blockStore := tmstore.NewBlockStore(tmdb) | ||
|
|
||
| stateDB, err := tmnode.DefaultDBProvider(&tmnode.DBContext{ID: "state", Config: cfg}) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| stateStore := sm.NewStore(stateDB) | ||
|
|
||
| store, err := tmnode.DefaultDBProvider(&tmnode.DBContext{ID: "tx_index", Config: cfg}) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| txIndexer := kv.NewTxIndex(store) | ||
|
|
||
| return &tmDB{ | ||
| blockStore, stateStore, txIndexer, | ||
| }, nil | ||
| } | ||
|
|
||
| func findUnluckyTx(blockResult *tmstate.ABCIResponses) int { | ||
| for txIndex, txResult := range blockResult.DeliverTxs { | ||
| if rpc.TxExceedsBlockGasLimit(txResult) { | ||
| return txIndex | ||
| } | ||
| } | ||
| return -1 | ||
| } | ||
|
|
||
| func (db *tmDB) replayTx(anApp *app.App, height int64, txIndex int, initialHeight int64) (*abci.TxResult, error) { | ||
| // replay the tx and patch tx result | ||
| // replay and patch block | ||
| block := db.blockStore.LoadBlock(height) | ||
| if block == nil { | ||
| return nil, fmt.Errorf("block %d not found", height) | ||
| } | ||
| if err := anApp.LoadHeight(block.Header.Height - 1); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| pbh := block.Header.ToProto() | ||
| if pbh == nil { | ||
| return nil, errors.New("nil header") | ||
| } | ||
|
|
||
| byzVals := make([]abci.Evidence, 0) | ||
| for _, evidence := range block.Evidence.Evidence { | ||
| byzVals = append(byzVals, evidence.ABCI()...) | ||
| } | ||
|
|
||
| commitInfo := getBeginBlockValidatorInfo(block, db.stateStore, initialHeight) | ||
|
|
||
| _ = anApp.BeginBlock(abci.RequestBeginBlock{ | ||
| Hash: block.Hash(), | ||
| Header: *pbh, | ||
| ByzantineValidators: byzVals, | ||
| LastCommitInfo: commitInfo, | ||
| }) | ||
|
|
||
| // replay tx with infinite block gas meter, before v0.7.0 upgrade those unlucky txs are committed successfully. | ||
| anApp.WithBlockGasMeter(sdk.NewInfiniteGasMeter()) | ||
|
|
||
| // run txs of block | ||
| for _, tx := range block.Txs[:txIndex] { | ||
| anApp.DeliverTx(abci.RequestDeliverTx{Tx: tx}) | ||
| } | ||
|
|
||
| rsp := anApp.DeliverTx(abci.RequestDeliverTx{Tx: block.Txs[txIndex]}) | ||
| return &abci.TxResult{ | ||
| Height: block.Header.Height, | ||
| Index: uint32(txIndex), | ||
| Tx: block.Txs[txIndex], | ||
| Result: rsp, | ||
| }, nil | ||
| } | ||
|
|
||
| func (db *tmDB) patchDB(blockResult *tmstate.ABCIResponses, result *abci.TxResult) error { | ||
| if err := db.txIndexer.Index(result); err != nil { | ||
| return err | ||
| } | ||
| blockResult.DeliverTxs[result.Index] = &result.Result | ||
| if err := db.stateStore.SaveABCIResponses(result.Height, blockResult); err != nil { | ||
| return err | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func getBeginBlockValidatorInfo(block *tmtypes.Block, store sm.Store, | ||
| initialHeight int64) abci.LastCommitInfo { | ||
| voteInfos := make([]abci.VoteInfo, block.LastCommit.Size()) | ||
| // Initial block -> LastCommitInfo.Votes are empty. | ||
| // Remember that the first LastCommit is intentionally empty, so it makes | ||
| // sense for LastCommitInfo.Votes to also be empty. | ||
| if block.Height > initialHeight { | ||
| lastValSet, err := store.LoadValidators(block.Height - 1) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| // Sanity check that commit size matches validator set size - only applies | ||
| // after first block. | ||
| var ( | ||
| commitSize = block.LastCommit.Size() | ||
| valSetLen = len(lastValSet.Validators) | ||
| ) | ||
| if commitSize != valSetLen { | ||
| panic(fmt.Sprintf( | ||
| "commit size (%d) doesn't match valset length (%d) at height %d\n\n%v\n\n%v", | ||
| commitSize, valSetLen, block.Height, block.LastCommit.Signatures, lastValSet.Validators, | ||
| )) | ||
| } | ||
|
|
||
| for i, val := range lastValSet.Validators { | ||
| commitSig := block.LastCommit.Signatures[i] | ||
| voteInfos[i] = abci.VoteInfo{ | ||
| Validator: tmtypes.TM2PB.Validator(val), | ||
| SignedLastBlock: !commitSig.Absent(), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return abci.LastCommitInfo{ | ||
| Round: block.LastCommit.Round, | ||
| Votes: voteInfos, | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.