Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: state-sync snapshot is not saved locally for local restoration #1022

Closed
wants to merge 2 commits into from

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 8, 2023

  • Restoration is slow, it's useful to save the chunks first and try local restoration later.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

- Restoration is slow, it's useful to save the chunks first and try local restoration later.
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #1022 (a65556d) into main (6765a82) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
- Coverage   45.32%   45.23%   -0.09%     
==========================================
  Files          80       81       +1     
  Lines        6718     6731      +13     
==========================================
  Hits         3045     3045              
- Misses       3354     3367      +13     
  Partials      319      319              
Impacted Files Coverage Δ
app/snapshot.go 0.00% <0.00%> (ø)

app/app.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
yihuang added a commit to yihuang/cronos that referenced this pull request May 8, 2023
…on (backport: crypto-org-chain#1022)

- Restoration is slow, it's useful to save the chunks first and try local restoration later.
yihuang added a commit to yihuang/cronos that referenced this pull request May 8, 2023
…on (backport: crypto-org-chain#1022)

- Restoration is slow, it's useful to save the chunks first and try local restoration later.
@yihuang
Copy link
Collaborator Author

yihuang commented May 9, 2023

ported to cosmos-sdk: cosmos/cosmos-sdk#16060

@yihuang yihuang closed this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant