Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: v1.0.10 changelog is not reviewed #1080

Merged
merged 6 commits into from
Jul 4, 2023
Merged

Problem: v1.0.10 changelog is not reviewed #1080

merged 6 commits into from
Jul 4, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jun 23, 2023 •
edited
Loading

open PR to review dependency changelogs between v1.0.9 and this PR (v1.0.10)

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang
Problem: v1.0.10 changelog is not reviewed
f9479c1 
open PR to review dependency changelogs
@yihuang yihuang marked this pull request as ready for review June 23, 2023 08:57
@yihuang yihuang requested a review from a team as a code owner June 23, 2023 08:57
@yihuang yihuang requested review from calvinaco, devashishdxt, mmsqe, lezzokafka, thomas-nguy and a team and removed request for a team June 23, 2023 08:57
@yihuang
Copy link
Collaborator Author

yihuang commented Jun 23, 2023

@mmsqe this is for reviewing all the dependency changes, for accidental consensus breaking changes.

thomas-nguy
thomas-nguy approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First parse looks okay

I can see a breaking change in cometBFT but I dont think it is a consensus breaking change for cosmos sdk

-[crypto/merkle]` Do not allow verification of Merkle Proofs against empty trees (`nil` root). `Proof.ComputeRootHash` now panics when it encounters an error, but `Proof.Verify` does not panic
  ([\#558](https://github.com/cometbft/cometbft/issues/558)))

Just to confirm, memiavl is only use in-memory ?

@yihuang
Copy link
Collaborator Author

yihuang commented Jun 26, 2023 •
edited
Loading

Just to confirm, memiavl is only use in-memory ?

it's on-disk, based on mmap-ed files.

yihuang
yihuang commented Jun 27, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yihuang yihuang enabled auto-merge (squash) July 4, 2023 03:12
@yihuang yihuang merged commit 0a4a09f into crypto-org-chain:release/v1.0.x Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmsqe mmsqe mmsqe approved these changes

@calvinaco calvinaco calvinaco approved these changes

@lezzokafka lezzokafka lezzokafka approved these changes

@thomas-nguy thomas-nguy thomas-nguy approved these changes

@devashishdxt devashishdxt Awaiting requested review from devashishdxt devashishdxt is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yihuang @mmsqe @calvinaco @lezzokafka @thomas-nguy