Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: sdk v47 is not used #1121

Merged
merged 33 commits into from
Sep 6, 2023
Merged

Problem: sdk v47 is not used #1121

merged 33 commits into from
Sep 6, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Aug 1, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 1, 2023
View reviewed changes
app/app.go
Comment on lines +913 to +915
for acc := range maccPerms {
blockedAddrs[authtypes.NewModuleAddress(acc).String()] = !allowedReceivingModAcc[acc]
}

Check failure

Code scanning / gosec

the value in the range statement should be _ unless copying a map: want: for key := range m Error

expected either an append, delete, or copy to another map in a range with a map
x/cronos/client/cli/tx.go Fixed Show fixed Hide fixed
x/cronos/client/cli/tx.go Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 1, 2023
View reviewed changes
app/app.go
Comment on lines +913 to +915
for acc := range maccPerms {
blockedAddrs[authtypes.NewModuleAddress(acc).String()] = !allowedReceivingModAcc[acc]
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
@codecov
Copy link

codecov bot commented Aug 1, 2023 •
edited
Loading

Codecov Report

Merging #1121 (3142c42) into main (c575f47) will increase coverage by 0.07%.
The diff coverage is 70.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1121      +/-   ##
==========================================
+ Coverage   46.54%   46.62%   +0.07%     
==========================================
  Files         105      104       -1     
  Lines        7923     7900      -23     
==========================================
- Hits         3688     3683       -5     
+ Misses       3856     3843      -13     
+ Partials      379      374       -5
Files Changed Coverage Δ
app/encoding.go 100.00% <ø> (ø)
app/state.go 0.00% <0.00%> (ø)
memiavl/db.go 59.87% <ø> (ø)
memiavl/import.go 64.64% <ø> (ø)
memiavl/iterator.go 79.71% <ø> (ø)
memiavl/tree.go 78.12% <ø> (ø)
versiondb/client/cmd.go 0.00% <ø> (ø)
versiondb/client/dump.go 0.00% <ø> (ø)
versiondb/client/restore.go 0.00% <ø> (ø)
versiondb/client/restore_app_db.go 0.00% <0.00%> (ø)
... and 18 more

... and 3 files with indirect coverage changes

@mmsqe mmsqe marked this pull request as ready for review September 6, 2023 03:21
@mmsqe mmsqe requested a review from a team as a code owner September 6, 2023 03:21
@mmsqe mmsqe requested review from yihuang and devashishdxt and removed request for a team September 6, 2023 03:21
yihuang
yihuang approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yihuang
yihuang reviewed Sep 6, 2023
View reviewed changes
go.mod Show resolved Hide resolved
@mmsqe mmsqe added this pull request to the merge queue Sep 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2023
@mmsqe mmsqe added this pull request to the merge queue Sep 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2023
@yihuang yihuang added this pull request to the merge queue Sep 6, 2023
Merged via the queue into crypto-org-chain:main with commit 8510f18 Sep 6, 2023
20 of 24 checks passed
@yihuang yihuang mentioned this pull request Sep 7, 2023
Closed
16 tasks
@coderabbitai coderabbitai bot mentioned this pull request Apr 19, 2024
Merged
13 tasks
This was referenced Apr 26, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihuang yihuang yihuang approved these changes

@devashishdxt devashishdxt Awaiting requested review from devashishdxt devashishdxt is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmsqe @yihuang