Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: no stateful precompiled contract for ica #1163

Merged
merged 49 commits into from
Sep 25, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Sep 12, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

x/icaauth/keeper/keeper.go Fixed Show fixed Hide fixed
x/cronos/keeper/precompiles/ica.go Fixed Show fixed Hide fixed
x/cronos/keeper/precompiles/ica.go Fixed Show fixed Hide fixed
x/cronos/keeper/precompiles/ica.go Fixed Show fixed Hide fixed
x/cronos/keeper/precompiles/ica.go Fixed Show fixed Hide fixed
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #1163 (7357456) into main (a47e6b1) will decrease coverage by 0.93%.
The diff coverage is 3.45%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1163      +/-   ##
==========================================
- Coverage   38.53%   37.61%   -0.93%     
==========================================
  Files         115      114       -1     
  Lines        9810    10077     +267     
==========================================
+ Hits         3780     3790      +10     
- Misses       5652     5907     +255     
- Partials      378      380       +2     
Files Changed Coverage Δ
...dings/cosmos/precompile/ica/i_ica_module.abigen.go 0.00% <0.00%> (ø)
x/cronos/events/decoders.go 0.00% <0.00%> (ø)
x/cronos/events/event.go 35.52% <0.00%> (ø)
x/cronos/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/cronos/keeper/precompiles/relayer.go 9.23% <0.00%> (-0.15%) ⬇️
x/cronos/keeper/precompiles/utils.go 0.00% <0.00%> (ø)
x/cronos/rpc/api.go 0.35% <0.00%> (ø)
x/icaauth/keeper/keeper.go 13.63% <0.00%> (-5.12%) ⬇️
x/icaauth/keeper/msg_server.go 100.00% <ø> (ø)
x/cronos/keeper/precompiles/ica.go 6.14% <6.14%> (ø)
... and 1 more

@mmsqe mmsqe marked this pull request as ready for review September 12, 2023 02:54
@mmsqe mmsqe requested a review from a team as a code owner September 12, 2023 02:54
@mmsqe mmsqe requested review from JayT106 and devashishdxt and removed request for a team September 12, 2023 02:54
@mmsqe mmsqe marked this pull request as draft September 13, 2023 08:08
@mmsqe mmsqe force-pushed the ica_precompile branch 2 times, most recently from 692232c to d2d7c20 Compare September 16, 2023 01:24
x/cronos/keeper/precompiles/ica.go Fixed Show fixed Hide fixed
x/cronos/keeper/precompiles/ica.go Fixed Show fixed Hide fixed
x/icaauth/client/cli/tx_submit_tx.go Fixed Show fixed Hide fixed
x/icaauth/client/cli/tx.go Fixed Show fixed Hide fixed
x/cronos/keeper/precompiles/relayer.go Fixed Show fixed Hide fixed
x/cronos/keeper/precompiles/ica.go Fixed Show fixed Hide fixed
x/cronos/keeper/precompiles/ica.go Fixed Show fixed Hide fixed
x/cronos/keeper/precompiles/ica.go Fixed Show fixed Hide fixed
x/cronos/keeper/precompiles/ica.go Fixed Show fixed Hide fixed
x/cronos/keeper/precompiles/ica.go Fixed Show fixed Hide fixed
x/cronos/keeper/precompiles/ica.go Fixed Show fixed Hide fixed
x/cronos/events/events.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two minor suggestions:

  • use new method CacheContext to execute queries
  • maybe remove default decoder, and make converted attributes explicit.

@mmsqe mmsqe added this pull request to the merge queue Sep 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2023
@mmsqe mmsqe added this pull request to the merge queue Sep 25, 2023
Merged via the queue into crypto-org-chain:main with commit 3313f54 Sep 25, 2023
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants