Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: more tx throughput is not enabled #1186

Merged
merged 12 commits into from
Sep 28, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 27, 2023

Solution:

  • due to improved performance, we can enlarge block gas limit to enable more tx throughput.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- due to improved performance, we can enlarge block gas limit to enable more tx throughput.
@yihuang yihuang requested a review from a team as a code owner September 27, 2023 07:44
@yihuang yihuang requested review from mmsqe, JayT106, calvinaco and lezzokafka and removed request for a team September 27, 2023 07:44
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
CHANGELOG.md Outdated Show resolved Hide resolved
yihuang and others added 3 commits September 27, 2023 16:14
Co-authored-by: Thomas Nguy <81727899+thomas-nguy@users.noreply.github.com>
Signed-off-by: yihuang <huang@crypto.com>
Signed-off-by: yihuang <huang@crypto.com>
@yihuang yihuang requested a review from thomas-nguy September 27, 2023 08:36
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #1186 (2c58e5b) into main (2dd9c8b) will decrease coverage by 0.03%.
The diff coverage is 14.28%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1186      +/-   ##
==========================================
- Coverage   36.85%   36.83%   -0.03%     
==========================================
  Files         115      115              
  Lines       10161    10167       +6     
==========================================
  Hits         3745     3745              
- Misses       6043     6049       +6     
  Partials      373      373              
Files Coverage Δ
app/upgrades.go 46.66% <14.28%> (-3.34%) ⬇️

@mmsqe mmsqe enabled auto-merge September 27, 2023 11:51
Signed-off-by: mmsqe <mavis@crypto.com>
@mmsqe mmsqe added this pull request to the merge queue Sep 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 27, 2023
@mmsqe mmsqe enabled auto-merge September 27, 2023 14:07
@mmsqe mmsqe added this pull request to the merge queue Sep 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 27, 2023
@yihuang yihuang added this pull request to the merge queue Sep 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 28, 2023
@mmsqe mmsqe added this pull request to the merge queue Sep 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 28, 2023
@mmsqe mmsqe added this pull request to the merge queue Sep 28, 2023
Merged via the queue into crypto-org-chain:main with commit b2ac3c7 Sep 28, 2023
@yihuang yihuang deleted the block-gas-limit branch September 28, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants