-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: more tx throughput is not enabled #1186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: - due to improved performance, we can enlarge block gas limit to enable more tx throughput.
yihuang
requested review from
mmsqe,
JayT106,
calvinaco and
lezzokafka
and removed request for
a team
September 27, 2023 07:44
yihuang
commented
Sep 27, 2023
Signed-off-by: yihuang <huang@crypto.com>
thomas-nguy
reviewed
Sep 27, 2023
Co-authored-by: Thomas Nguy <81727899+thomas-nguy@users.noreply.github.com> Signed-off-by: yihuang <huang@crypto.com>
Signed-off-by: yihuang <huang@crypto.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1186 +/- ##
==========================================
- Coverage 36.85% 36.83% -0.03%
==========================================
Files 115 115
Lines 10161 10167 +6
==========================================
Hits 3745 3745
- Misses 6043 6049 +6
Partials 373 373
|
calvinaco
approved these changes
Sep 27, 2023
Signed-off-by: mmsqe <mavis@crypto.com>
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sep 27, 2023
JayT106
approved these changes
Sep 27, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sep 27, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)