Problem: upgrade test nix package is incorrect

[yihuang]

Solution:

• revert the tarball change
• recursively copy the package to make it writable.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• New Features

  • Introduced a new method for creating tarballs that enhances security and standardizes extraction processes.

• Refactor

  • Updated directory linking logic in integration tests for improved clarity and efficiency.
  • Modified upgrade test strategy to enhance test reliability and performance.

• Chores

  • Removed outdated tarball creation functionality to streamline the build process.

[coderabbitai]

Walkthrough

The recent updates refine file handling processes within the project, enhancing efficiency and reliability. A notable addition in flake.nix streamlines packaging by creating tarballs with optimized file handling. Changes in integration tests and build scripts simplify linking directories, improve file permissions testing, and remove specific ownership/permissions for tarball creation.

Changes

File Path	Change Summary
flake.nix	Added make-tarball attribute for optimized tarball creation.
integration_tests/configs/upgrade-test-package.nix, nix/build_overlay.nix	Updated directory linking logic and removed specific tarball ownership/permissions.
integration_tests/test_upgrade.py	Modified to copy content for writability, adjusting permissions using shutil.copytree.

"In the realm of code, where the bits do roam,
A rabbit hopped in, making this its home.
🐰 With a hop and a skip, changes were made,
Files and directories, perfectly laid.
No more duplicates, permissions so fine,
In this digital burrow, everything's divine!"

---

Recent Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 58ce7f4 and d399564.

Files selected for processing (4)

• flake.nix (1 hunks)
• integration_tests/configs/upgrade-test-package.nix (1 hunks)
• integration_tests/test_upgrade.py (2 hunks)
• nix/build_overlay.nix (1 hunks)

Files skipped from review as they are similar to previous changes (4)

• flake.nix
• integration_tests/configs/upgrade-test-package.nix
• integration_tests/test_upgrade.py
• nix/build_overlay.nix

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.47%. Comparing base (58ce7f4) to head (d399564).

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1384       +/-   ##
===========================================
- Coverage   36.51%   16.47%   -20.05%     
===========================================
  Files         129       80       -49     
  Lines        9606     5124     -4482     
===========================================
- Hits         3508      844     -2664     
+ Misses       5721     4204     -1517     
+ Partials      377       76      -301     

see 73 files with indirect coverage changes