Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: proto-gen fails in CI #1392

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Apr 15, 2024

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

Closes #1391

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Chores
    • Enhanced Docker run configuration for building protocols to manage permissions effectively.
    • Updated job name and corresponding make command in workflow for better clarity.
    • Modified workflow comments related to Swagger generation and documentation.

Copy link
Contributor

coderabbitai bot commented Apr 15, 2024

Walkthrough

The recent update in the codebase involves adjustments to the Makefile and .github/workflows/proto.yml. These changes aim to enhance the Docker run configuration for building protocols and streamline the workflow for protocol generation in CI environments.

Changes

File Change Summary
Makefile Added --user root flag to protoImage command in Docker run configuration for building protocols
.github/workflows/proto.yml Renamed job to proto-gen-ci, updated related make command to make proto-genci, and refined workflow comments

Assessment against linked issues

Objective Addressed Explanation
Problem: proto-gen fails in CI (#1391)

Poem

🐇 In the code's domain we find,
Changes made with a thoughtful mind.
--user root now takes its place,
Resolving bugs with coding grace.
CI flows smoother, issues at bay,
Progress made, a brighter day.


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 0290926 and 227db18.
Files selected for processing (2)
  • .github/workflows/proto.yml (1 hunks)
  • Makefile (2 hunks)
Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/proto.yml
  • Makefile

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mmsqe mmsqe force-pushed the fix_proto_gen branch 2 times, most recently from b9c1e6c to 6f63062 Compare April 15, 2024 03:07
@yihuang
Copy link
Collaborator

yihuang commented Apr 15, 2024

it only reproduce in #1377

@mmsqe
Copy link
Collaborator Author

mmsqe commented Apr 15, 2024

it only reproduce in #1377

I thought it was an old issue, seems don't have github.com directory

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.35%. Comparing base (cae2cd5) to head (227db18).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1392       +/-   ##
===========================================
- Coverage   35.31%   15.35%   -19.97%     
===========================================
  Files         124       75       -49     
  Lines        9458     4925     -4533     
===========================================
- Hits         3340      756     -2584     
+ Misses       5759     4094     -1665     
+ Partials      359       75      -284     

see 70 files with indirect coverage changes

@mmsqe mmsqe marked this pull request as ready for review April 17, 2024 02:13
@mmsqe mmsqe requested a review from a team as a code owner April 17, 2024 02:13
@mmsqe mmsqe requested review from yihuang and devashishdxt and removed request for a team April 17, 2024 02:13
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@mmsqe mmsqe enabled auto-merge April 17, 2024 04:01
@mmsqe mmsqe added this pull request to the merge queue Apr 17, 2024
Merged via the queue into crypto-org-chain:main with commit 39a0261 Apr 17, 2024
41 of 42 checks passed
mmsqe added a commit to yihuang/cronos that referenced this pull request May 2, 2024
* Problem: proto-gen fails in CI

* Apply suggestions from code review
yihuang added a commit to yihuang/cronos that referenced this pull request May 3, 2024
Problem: no end-to-end encryption module (crypto-org-chain#1407)

* Problem: no end-to-end encryption module

add keeper

add grpc query

signer option

getter/setter

genesis init/export

fix lint

* fix proto lint

* fix test

* register codec

* changelog

* fix build

* Update x/e2ee/types/keys.go

Co-authored-by: mmsqe <mavis@crypto.com>
Signed-off-by: yihuang <huang@crypto.com>

* Update x/e2ee/types/codec.go

Co-authored-by: mmsqe <mavis@crypto.com>
Signed-off-by: yihuang <huang@crypto.com>

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>

Problem: encryption-key cmd is not supported (crypto-org-chain#1409)

* Problem: encryption-key cmd is not supported

* gen doc

* add validate

Problem: no keyring interface for e2ee to store arbitrary payload (crypto-org-chain#1413)

changelo

add age encrypt/decrypt in unit test

Update x/e2ee/keyring/keyring.go

Signed-off-by: yihuang <huang@crypto.com>

fix lint

fix build

Problem: no encrypt and decrypt cmds for message (crypto-org-chain#1411)

* Problem: no encrypt and decrypt cmds for message

* fix doc

* add gen

* test

* cleanup

* move command to e2ee module

move encrypt cmd to e2ee module

move decrypt cmd to e2ee

update integration test

store key as string, to make autocli better

fix integration test

Update x/e2ee/client/cli/encrypt.go

Signed-off-by: yihuang <huang@crypto.com>

fix lint

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: yihuang <yi.codeplayer@gmail.com>

Problem: no efficient batch query for encryption keys (crypto-org-chain#1415)

Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

update swagger

typo

fix build

proposal handler

update version

check exist

Problem: proto-gen fails in CI (crypto-org-chain#1392)

* Problem: proto-gen fails in CI

* Apply suggestions from code review

add cronos msg

add store-block-list cmd

refresh block list

add handler

update deps

add handler

lint

fix cmd

test store list

set with ante

move to util

fix ibc

Revert "set with ante"

This reverts commit c2700f5.

reject on err

fix prepare proposal

fix proto lint
yihuang added a commit that referenced this pull request May 6, 2024
* Problem: e2ee module is not backported

Problem: no end-to-end encryption module (#1407)

* Problem: no end-to-end encryption module

add keeper

add grpc query

signer option

getter/setter

genesis init/export

fix lint

* fix proto lint

* fix test

* register codec

* changelog

* fix build

* Update x/e2ee/types/keys.go

Co-authored-by: mmsqe <mavis@crypto.com>
Signed-off-by: yihuang <huang@crypto.com>

* Update x/e2ee/types/codec.go

Co-authored-by: mmsqe <mavis@crypto.com>
Signed-off-by: yihuang <huang@crypto.com>

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>

Problem: encryption-key cmd is not supported (#1409)

* Problem: encryption-key cmd is not supported

* gen doc

* add validate

Problem: no keyring interface for e2ee to store arbitrary payload (#1413)

changelo

add age encrypt/decrypt in unit test

Update x/e2ee/keyring/keyring.go

Signed-off-by: yihuang <huang@crypto.com>

fix lint

fix build

Problem: no encrypt and decrypt cmds for message (#1411)

* Problem: no encrypt and decrypt cmds for message

* fix doc

* add gen

* test

* cleanup

* move command to e2ee module

move encrypt cmd to e2ee module

move decrypt cmd to e2ee

update integration test

store key as string, to make autocli better

fix integration test

Update x/e2ee/client/cli/encrypt.go

Signed-off-by: yihuang <huang@crypto.com>

fix lint

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: yihuang <yi.codeplayer@gmail.com>

Problem: no efficient batch query for encryption keys (#1415)

Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

update swagger

typo

fix build

proposal handler

update version

check exist

Problem: proto-gen fails in CI (#1392)

* Problem: proto-gen fails in CI

* Apply suggestions from code review

add cronos msg

add store-block-list cmd

refresh block list

add handler

update deps

add handler

lint

fix cmd

test store list

set with ante

move to util

fix ibc

Revert "set with ante"

This reverts commit c2700f5.

reject on err

fix prepare proposal

fix proto lint

* cmd to encrypt to validators

* fix test

* temp

* fix test

* improve test

* Problem: no validate for malformed e2ee key in register (#1421)

* Problem: no validate for malformed e2ee key in register

* update doc

* Apply suggestions from code review

* cleanup

---------

Co-authored-by: yihuang <yi.codeplayer@gmail.com>

* cleanup test

* revert

* fix test

* fix test

* remove mempool blocked-addresses

* fix test

* fix test

* fix test

* fix patch

* avoid prompt

* encrypt clear list

* cleanup

* add validate

* avoid concurrent mutate

* Update app/proposal.go

Signed-off-by: mmsqe <mavis@crypto.com>

* cleanup

* proto-gen

---------

Signed-off-by: yihuang <huang@crypto.com>
Signed-off-by: mmsqe <mavis@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: proto-gen fails in CI
2 participants