Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: sim tests fails #1394

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Problem: sim tests fails #1394

merged 3 commits into from
Apr 16, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 15, 2024

Solution:

  • add icahost wiring, but disable in parameters

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • New Features

    • Introduced a new, but initially disabled, feature related to "icahost wirings" for enhanced interchain account functionalities.
    • Added middleware and routing updates to support the icahost module in interchain accounts.
  • Refactor

    • Updated imports and added new keepers for interchain account management.
  • Tests

    • Enhanced simulation tests to explicitly set the chain ID during context initialization.
  • Chores

    • Implemented mock subspace for parameter handling in the interchain accounts module.
    • Updated upgrade handling logic to set parameters and perform actions based on upgrade data.

@yihuang yihuang requested a review from a team as a code owner April 15, 2024 23:48
@yihuang yihuang requested review from calvinaco and leejw51crypto and removed request for a team April 15, 2024 23:48
Copy link
Contributor

coderabbitai bot commented Apr 15, 2024

Walkthrough

The recent update introduces a new feature related to "icahost wirings" in the software, focusing on interchain accounts. Although the feature is added across several files, it's not enabled by default. Changes include the addition of new modules, keepers, and middleware, as well as adjustments to existing test setups and upgrade handling mechanisms.

Changes

Files Change Summary
CHANGELOG.md Added a new feature related to "icahost wirings", disabled by default.
app/app.go, app/icahost.go Introduced new imports, keepers, and middleware for the interchain accounts module; added a mock subspace for handling parameters.
app/sim_test.go Modified test setups to explicitly set the chain ID.
app/upgrades.go Enhanced upgrade handling logic, involving setting parameters and reading upgrade information.

🐰✨
In the land of code, where the bits align,
A new feature sprouts, 'tis yet to shine.
With wirings so vast, in silence it waits,
For the flip of a switch, to open the gates.
Hop, hop, hurray, for changes so bright,
In the burrows of data, they bring new light! 🌟
🐰💻


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8bbc74d and d617ac0.
Files selected for processing (1)
  • app/icahost.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/icahost.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yihuang
Copy link
Collaborator Author

yihuang commented Apr 15, 2024

/runsim

Copy link

Simulation tests get triggered and started by /runsim.
Please check further progress here

Copy link

/runsim simulation test has failed 😅
Please further check here

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@yihuang
Copy link
Collaborator Author

yihuang commented Apr 16, 2024

/runsim

Copy link

Simulation tests get triggered and started by /runsim.
Please check further progress here

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

CHANGELOG.md Show resolved Hide resolved
Copy link

/runsim simulation test has failed 😅
Please further check here

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 35.38%. Comparing base (eda35d7) to head (d617ac0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1394      +/-   ##
==========================================
- Coverage   35.42%   35.38%   -0.05%     
==========================================
  Files         123      124       +1     
  Lines        9422     9440      +18     
==========================================
+ Hits         3338     3340       +2     
- Misses       5727     5741      +14     
- Partials      357      359       +2     
Files Coverage Δ
app/icahost.go 0.00% <0.00%> (ø)
app/upgrades.go 19.04% <11.11%> (-20.96%) ⬇️

Copy link

Simulation tests get triggered and started by /runsim.
Please check further progress here

app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
Copy link

/runsim simulation test has failed 😅
Please further check here

@mmsqe
Copy link
Collaborator

mmsqe commented Apr 16, 2024

Might need wait a bit cosmos/ibc-go#6167

@yihuang
Copy link
Collaborator Author

yihuang commented Apr 16, 2024

/runsim

Copy link

/runsim simulation test has failed 😅
Please further check here

Copy link

Simulation tests get triggered and started by /runsim.
Please check further progress here

Copy link

/runsim simulation test has failed 😅
Please further check here

Copy link

Simulation tests get triggered and started by /runsim.
Please check further progress here

Copy link

/runsim simulation test has failed 😅
Please further check here

@yihuang
Copy link
Collaborator Author

yihuang commented Apr 16, 2024

/runsim

Copy link

Simulation tests get triggered and started by /runsim.
Please check further progress here

Copy link

/runsim simulation test has failed 😅
Please further check here

@yihuang
Copy link
Collaborator Author

yihuang commented Apr 16, 2024

/runsim

Copy link

Simulation tests get triggered and started by /runsim.
Please check further progress here

Copy link

/runsim simulation test has succeeded 🎉
Please further check here

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

app/icahost.go Show resolved Hide resolved
app/icahost.go Outdated Show resolved Hide resolved
Solution:
- add icahost wiring, but disable in parameters

fix build

Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

Update app/app.go

Co-authored-by: mmsqe <mavis@crypto.com>
Signed-off-by: yihuang <huang@crypto.com>

Update app/app.go

Co-authored-by: mmsqe <mavis@crypto.com>
Signed-off-by: yihuang <huang@crypto.com>

fix chain-id

fix upgrade

add missing file

Update app/icahost.go

Signed-off-by: yihuang <huang@crypto.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

app/icahost.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants