Problem: integration test don't verify app hash between block-stm and #1538
Conversation
sequential Solution: - only enable block-stm on one of the node, try to detect potencial app hash mismatch
yihuang
requested review from
JayT106 and
leejw51crypto
and removed request for
a team
WalkthroughThe recent changes reorganize the configuration settings in Changes
Sequence Diagram(s)(No sequence diagrams generated as the changes do not involve new features or modifications to control flow.) Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Signed-off-by: yihuang <huang@crypto.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- integration_tests/configs/default.jsonnet (2 hunks)
Additional comments not posted (2)
integration_tests/configs/default.jsonnet (2)
29-29: Verify the impact of removing theevmblock from themempoolsection.Ensure that removing the
evmblock from themempoolsection does not affect any dependent functionality or configurations.
47-49: Ensure correct integration of theevmblock in theversiondbsection.Verify that the
evmblock is correctly integrated within theversiondbsection for validators and that it does not cause any issues with the existing configuration.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- integration_tests/configs/default.jsonnet (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- integration_tests/configs/default.jsonnet
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1538 +/- ##
=======================================
Coverage 15.24% 15.24%
=======================================
Files 67 67
Lines 4874 4874
=======================================
Hits 743 743
Misses 4037 4037
Partials 94 94 |
Signed-off-by: yihuang <huang@crypto.com>
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- integration_tests/configs/default.jsonnet (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- integration_tests/configs/default.jsonnet
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- integration_tests/configs/default.jsonnet (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- integration_tests/configs/default.jsonnet
sequential
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
New Features
Bug Fixes
mempoolandversiondbsettings.