Problem: cometbft not up to date #1568
Conversation
update to 0.38.12
yihuang
requested review from
JayT106,
thomas-nguy and
mmsqe
and removed request for
a team
WalkthroughThe changes involve updates to dependency versions across multiple files, including Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: yihuang <huang@crypto.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1568 +/- ##
===========================================
+ Coverage 15.24% 36.12% +20.88%
===========================================
Files 67 97 +30
Lines 4874 7725 +2851
===========================================
+ Hits 743 2791 +2048
- Misses 4037 4585 +548
- Partials 94 349 +255 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (3)
- CHANGELOG.md (1 hunks)
- go.mod (7 hunks)
- gomod2nix.toml (12 hunks)
Files skipped from review due to trivial changes (1)
- CHANGELOG.md
Additional comments not posted (28)
go.mod (7)
22-22: Approved version update.The minor version update to
github.com/cometbft/cometbftfromv0.38.11tov0.38.12is approved. It likely includes bug fixes or performance improvements.
25-25: Approved version update.The minor version update to
github.com/cosmos/gogoprotofromv1.4.12tov1.7.0is approved. It likely includes enhancements or new features.
40-42: Approved version updates.The minor version updates to
github.com/spf13/cobrafromv1.8.0tov1.8.1andgithub.com/spf13/viperfromv1.18.2tov1.19.0are approved. They likely include bug fixes or performance improvements.
45-45: Approved version update with potential critical security updates.The substantial version update to
golang.org/x/cryptofromv0.22.0tov0.26.0is approved. It may include critical security updates, so it's important to review the changelog and update accordingly.
53-56: Approved version updates.The minor version updates to
cloud.google.com/gofromv0.112.0tov0.112.1andcloud.google.com/go/storagefromv1.37.0tov1.38.0are approved. They likely include bug fixes or performance improvements.
191-194: Approved version updates.The minor version updates to
github.com/prometheus/client_golangfromv1.20.0tov1.20.1,github.com/prometheus/commonfromv0.52.2tov0.55.0, andgithub.com/prometheus/procfsfromv0.15.0tov0.15.1are approved. They likely include bug fixes, performance improvements, enhancements, or new features.
223-241: Approved version updates with potential critical updates.The version updates to the
golang.org/xpackages, includingcrypto,net,oauth2,sync,sys,term,text, andtools, are approved. The substantial version changes may include critical security updates, enhancements, or new features, so it's important to review the changelogs and update accordingly.The minor version updates to the
google.golang.orgpackages, includingapiandgenproto, are also approved. They likely include bug fixes or performance improvements.gomod2nix.toml (21)
5-6: LGTM!The changes to update the module version and hash look good.
8-9: LGTM!The changes to update the module version and hash look good.
14-15: LGTM!The changes to update the module version and hash look good.
111-112: LGTM!The changes to update the module version and hash look good.
114-115: LGTM!The changes to update the module version and hash look good.
117-118: LGTM!The changes to update the module version and hash look good.
138-139: LGTM!The changes to update the module version and hash look good.
154-155: LGTM!The changes to update the module version and hash look good.
180-181: LGTM!The changes to update the module version and hash look good.
350-351: LGTM!The changes to update the module version and hash look good.
359-360: LGTM!The changes to update the module version and hash look good.
440-441: LGTM!The changes to update the module version and hash look good.
487-489: LGTM!The changes to add a new module look good.
500-501: LGTM!The changes to update the module version and hash look good.
512-513: LGTM!The changes to update the module version and hash look good.
518-519: LGTM!The changes to update the module version and hash look good.
521-522: LGTM!The changes to update the module version and hash look good.
530-531: LGTM!The changes to update the module version and hash look good.
557-558: LGTM!The changes to update the module version and hash look good.
563-564: LGTM!The changes to update the module version and hash look good.
628-629: LGTM!The changes to update the module version and hash look good.
update to 0.38.12
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
Documentation
Dependency Updates
github.com/cometbft/cometbftto v0.38.12github.com/cosmos/gogoprototo v1.7.0github.com/spf13/cobrato v1.8.1github.com/spf13/viperto v1.19.0golang.org/x/cryptoto v0.26.0