Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Version CLI command doesn't output any text #178

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Oct 15, 2021

Closes: #177

Solution:

  • add ldflags to Makefile, goreleaser version is good

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Closes: crypto-org-chain#177

Solution:
- add ldflags to Makefile, goreleaser version is good
@yihuang yihuang requested a review from a team as a code owner October 15, 2021 01:09
@yihuang yihuang requested review from calvinaco and devashishdxt and removed request for a team October 15, 2021 01:09
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #178 (766904e) into main (3ea70c5) will increase coverage by 5.11%.
The diff coverage is 54.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   21.51%   26.63%   +5.11%     
==========================================
  Files          27       33       +6     
  Lines        1729     2328     +599     
==========================================
+ Hits          372      620     +248     
- Misses       1324     1662     +338     
- Partials       33       46      +13     
Impacted Files Coverage Δ
app/prefix.go 0.00% <0.00%> (ø)
app/test_helpers.go 0.00% <0.00%> (ø)
x/cronos/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/cronos/keeper/msg_server.go 5.00% <0.00%> (-1.46%) ⬇️
x/cronos/module.go 59.64% <0.00%> (-2.17%) ⬇️
x/cronos/types/codec.go 0.00% <0.00%> (ø)
x/cronos/types/events.go 0.00% <ø> (ø)
x/cronos/types/messages.go 20.22% <ø> (+20.22%) ⬆️
x/cronos/types/params.go 57.35% <ø> (+3.78%) ⬆️
x/cronos/types/proposal.go 11.11% <ø> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9426981...766904e. Read the comment docs.

Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This seems to work for release binaries

@yihuang
Copy link
Collaborator Author

yihuang commented Oct 15, 2021

LGTM

This seems to work for release binaries

yeah, goreleaser version has these flags already.

@yihuang yihuang merged commit e52941e into crypto-org-chain:main Oct 15, 2021
@yihuang yihuang deleted the cli-version branch October 15, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version CLI command doesn't output any text
2 participants