Problem: no integration test for EIP-1559 feature #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #249 +/- ##
===========================================
+ Coverage 21.51% 41.06% +19.54%
===========================================
Files 27 30 +3
Lines 1729 1505 -224
===========================================
+ Hits 372 618 +246
+ Misses 1324 841 -483
- Partials 33 46 +13
|
yihuang
commented
Dec 13, 2021
yihuang
commented
Dec 13, 2021
yihuang
commented
Dec 13, 2021
yihuang
force-pushed
the
eip-1559
branch
4 times, most recently
from
4dc76b3 to
d89eb97
Compare
yihuang
requested review from
calvinaco and
devashishdxt
and removed request for
a team
Closes: crypto-org-chain#245 Solution: - enable eip-1559 in integration test devnets - test dynamic fee tx and the fee calculation logic - test base fee adjustment lower initial base fee fix statesync test fix gravity test fix base fee adjustment
yihuang
force-pushed
the
eip-1559
branch
2 times, most recently
from
899eb73 to
8a34e92
Compare
yihuang
commented
Jan 17, 2022
integration_tests/test_basic.py
Outdated
| @@ -69,7 +69,7 @@ def test_events(cluster, suspend_capture): | |||
| def test_minimal_gas_price(cronos): | |||
| w3 = cronos.w3 | |||
| gas_price = w3.eth.gas_price | |||
| assert gas_price == 5000000000000 | |||
| # assert gas_price == 5000000000000 | |||
There was a problem hiding this comment.
gas price is not fixed now.
There was a problem hiding this comment.
specifying unit would be useful
There was a problem hiding this comment.
specifying unit would be useful
this assertion is removed because gas_price result is not constant anymore.
yihuang
commented
Jan 17, 2022
| @@ -12,6 +12,13 @@ in | |||
| import sources.nixpkgs { | |||
| overlays = [ | |||
| (_: pkgs: dapptools) # use released version to hit the binary cache | |||
| (_: pkgs: { | |||
| go-ethereum = pkgs.callPackage ./go-ethereum.nix { | |||
There was a problem hiding this comment.
to replace to a newer version to test eip-1559 logic.
| elasticity_multiplier = 2 | ||
| gas_target = gas_limit // elasticity_multiplier | ||
|
|
||
| delta = parent_fee * (gas_target - gas_used) // gas_target // change_denominator |
There was a problem hiding this comment.
some explanation for parent_fee?
There was a problem hiding this comment.
I linked the eip-1559 spec, it's basically the same code as the spec.
yihuang
commented
Jan 17, 2022
| @@ -137,6 +137,30 @@ def wait_for_ipc(path, timeout=40.0): | |||
| ) | |||
|
|
|||
|
|
|||
| def w3_wait_for_block(w3, height, timeout=240): | |||
| for i in range(timeout * 2): | |||
There was a problem hiding this comment.
why multiply with 2?
There was a problem hiding this comment.
because it sleep 0.5 seconds, multiply the loop count with 2 make total time closer to timeout as seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #245
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)