-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: batchTxExecuted use wrong contract address in gravity bridge module #323
Merged
thomas-nguy
merged 1 commit into
crypto-org-chain:main
from
thomas-nguy:thomas/update-gravity
Feb 2, 2022
Merged
Problem: batchTxExecuted use wrong contract address in gravity bridge module #323
thomas-nguy
merged 1 commit into
crypto-org-chain:main
from
thomas-nguy:thomas/update-gravity
Feb 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-nguy
requested review from
yihuang and
JayT106
and removed request for
a team
January 31, 2022 01:31
thomas-nguy
changed the title
Problem: Fix batchTxExecuted in gravity bridge module
Problem: batchTxExecuted use wrong contract address in gravity bridge module
Jan 31, 2022
Codecov Report
@@ Coverage Diff @@
## main #323 +/- ##
===========================================
+ Coverage 21.51% 41.06% +19.54%
===========================================
Files 27 30 +3
Lines 1729 1505 -224
===========================================
+ Hits 372 618 +246
+ Misses 1324 841 -483
- Partials 33 46 +13
|
thomas-nguy
force-pushed
the
thomas/update-gravity
branch
from
January 31, 2022 01:38
32af1f1
to
863e754
Compare
tomtau
reviewed
Jan 31, 2022
go.sum
Outdated
Comment on lines
841
to
842
github.com/peggyjv/gravity-bridge/module v0.3.4 h1:a3Nfcw8dM97sv5kOoF97NvnigB2rw1+dj84Bhuk94vg= | ||
github.com/peggyjv/gravity-bridge/module v0.3.4/go.mod h1:IFm0SoZGHzA8c6NH3YyRSl2sGT7qdxY+DimCrP2+J+4= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is v0.3.4 still depended on by anything?
thomas-nguy
force-pushed
the
thomas/update-gravity
branch
2 times, most recently
from
January 31, 2022 02:01
6d60154
to
73aff20
Compare
thomas-nguy
changed the title
Problem: batchTxExecuted use wrong contract address in gravity bridge module
[Draft] Problem: batchTxExecuted use wrong contract address in gravity bridge module
Jan 31, 2022
I will keep this PR open for the time being til sommelier do an official release |
thomas-nguy
force-pushed
the
thomas/update-gravity
branch
from
February 1, 2022 01:47
73aff20
to
617dc25
Compare
thomas-nguy
changed the title
[Draft] Problem: batchTxExecuted use wrong contract address in gravity bridge module
Problem: batchTxExecuted use wrong contract address in gravity bridge module
Feb 1, 2022
thomas-nguy
force-pushed
the
thomas/update-gravity
branch
from
February 1, 2022 01:54
617dc25
to
62f1dcd
Compare
yihuang
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
Solution: Bump gravity module version to latest main (d52551b27f65)
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)