-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: don't support debug query result (backport: #328) #342
Problem: don't support debug query result (backport: #328) #342
Conversation
44de505
to
77adc9b
Compare
77adc9b
to
a30fecc
Compare
a30fecc
to
16e7be9
Compare
why is this PR pointed to release/v0.6.x? |
it's a backport, the feature is backported to cosmos-sdk 0.44.x, for easier debugging. |
@@ -4,7 +4,7 @@ go 1.17 | |||
|
|||
require ( | |||
github.com/armon/go-metrics v0.3.9 | |||
github.com/cosmos/cosmos-sdk v0.44.3 | |||
github.com/cosmos/cosmos-sdk v0.44.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, it's: cosmos/cosmos-sdk@v0.44.3...8a26cd1
Solution: - update cosmos-sdk dependency changelog
16e7be9
to
cc628d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine after a quick check of the changelog of cosmos sdk
Just to confirm, events are not store in consensus hash right?
cosmos/cosmos-sdk#10631
I think it is stored in consensus hash, so it looks like breaking, maybe better to cherry-pick to a custom fork then. |
I think events used to be in the consensus in TM 0.33 or something like that, but it was later removed (it's up to ABCI apps to do it themselves now) |
that's great, @mofhusseini has run a node with this version, haven't seen app hash mismatch issue yet. |
Just for reference: events were perhaps hashed into block headers pre-0.33, not hashed in 0.33, but considered to be hashed again for 0.34, but it was decided not to hash them: tendermint/tendermint#5134 (comment) :D |
@tomtau is correct, the current block header doesn't have the event hash in v0.34 and later release. Only |
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)