Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: subscription deadlock fix is not backported to 0.6.x #352

Merged
merged 4 commits into from
Feb 21, 2022
Merged

Problem: subscription deadlock fix is not backported to 0.6.x #352

merged 4 commits into from
Feb 21, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Feb 21, 2022

Closes: #207
Solution:

  • backport the fix to 0.6.x

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner February 21, 2022 04:29
@yihuang yihuang requested review from calvinaco and devashishdxt and removed request for a team February 21, 2022 04:29
yihuang
yihuang commented Feb 21, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yihuang yihuang changed the title Problem: Websocket blocks after terminating without unsubscribing Problem: subscription deadlock fix is not backported to 0.6.x Feb 21, 2022
@thomas-nguy
Copy link
Collaborator

are we planning to do a v0.6.7 release?

@yihuang
Copy link
Collaborator Author

yihuang commented Feb 21, 2022 •
edited
Loading

are we planning to do a v0.6.7 release?

Later I think since we just released 0.6.6, but before that, the user can build from 0.6.x manually. This backport is asked by a user who wants to use the websocket subscription feature on current mainnet.

yihuang
yihuang commented Feb 21, 2022
View reviewed changes
go.mod
@@ -164,7 +164,7 @@ replace github.com/ethereum/go-ethereum => github.com/crypto-org-chain/go-ethere
// TODO: remove when ibc-go and ethermint upgrades cosmos-sdk
replace github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.44.7-0.20220214161517-8a26cd10b4be

replace github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.7.2-cronos-8
replace github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.7.2-cronos-9
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crypto-org-chain/ethermint@v0.7.2-cronos-8...v0.7.2-cronos-9

thomas-nguy
thomas-nguy approved these changes Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay lgtm

@yihuang yihuang merged commit 485d128 into crypto-org-chain:release/v0.6.x Feb 21, 2022
@yihuang yihuang deleted the backport-subscription-fix branch February 21, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-nguy thomas-nguy thomas-nguy approved these changes

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner automatically assigned from crypto-org-chain/cronos-dev

@devashishdxt devashishdxt Awaiting requested review from devashishdxt devashishdxt is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @thomas-nguy