Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: customer tx indexer feature is not enabled #549

Merged
merged 4 commits into from
Aug 16, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jun 9, 2022

Solution:

  • enable and test the custom tx indexer feature

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang force-pushed the indexer branch 4 times, most recently from c1c772b to 8295d20 Compare June 13, 2022 07:11
@yihuang yihuang marked this pull request as ready for review June 13, 2022 08:24
@yihuang yihuang requested a review from a team as a code owner June 13, 2022 08:24
@yihuang yihuang requested review from JayT106 and devashishdxt and removed request for a team June 13, 2022 08:24
go.mod Outdated Show resolved Hide resolved
@yihuang yihuang marked this pull request as draft June 14, 2022 04:07
@yihuang yihuang force-pushed the indexer branch 4 times, most recently from 504c1b9 to af1006b Compare July 4, 2022 06:40
Solution:
- enable and test the custom tx indexer feature

test seperate indexer in integration test

fix lint

fix cronos fixture

update nixpkgs for pystarport

fix nix stuff

update pystarport

fix integration test

revert nixpkgs

fix integration test

update ethermint

ethermint -> evmos

fix indexer cmd

fix indexer

gofmt
@yihuang yihuang marked this pull request as ready for review August 15, 2022 14:51
@JayT106
Copy link
Collaborator

JayT106 commented Aug 15, 2022

lgtm, do we need a migration guild/document for the operator to use the ethermint tx indexer?

@yihuang
Copy link
Collaborator Author

yihuang commented Aug 16, 2022

lgtm, do we need a migration guild/document for the operator to use the ethermint tx indexer?

maybe on a wiki page.

@yihuang yihuang merged commit c093016 into crypto-org-chain:main Aug 16, 2022
@yihuang yihuang deleted the indexer branch August 16, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants