Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: no integration test case for fee calculation of reverted contract call tx. #590

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Problem: no integration test case for fee calculation of reverted contract call tx. #590

merged 1 commit into from
Jul 25, 2022

Conversation

macong-cdc
Copy link
Collaborator

closes #294

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@macong-cdc macong-cdc requested a review from a team as a code owner July 18, 2022 08:01
@macong-cdc macong-cdc requested review from yihuang and adu-crypto and removed request for a team July 18, 2022 08:01
@yihuang yihuang self-requested a review July 18, 2022 09:59
yihuang
yihuang approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@thomas-nguy
Copy link
Collaborator

what is the purpose of this test?

Is it for the refund logic?

@macong-cdc
Copy link
Collaborator Author

what is the purpose of this test?

Is it for the refund logic?

Yes, it is for the refund logic for this issue.

@yihuang yihuang merged commit e574f14 into crypto-org-chain:main Jul 25, 2022
@macong-cdc macong-cdc deleted the test-revert-contract-call branch October 20, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihuang yihuang yihuang approved these changes

@thomas-nguy thomas-nguy thomas-nguy left review comments

@adu-crypto adu-crypto Awaiting requested review from adu-crypto adu-crypto is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: no integration test case for fee calculation of reverted contract call tx.
3 participants
@macong-cdc @thomas-nguy @yihuang