Problem: generic events format are not implemented #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-nguy
requested review from
JayT106 and
adu-crypto
and removed request for
a team
thomas-nguy
force-pushed
the
thomas/adr-007-implementation
branch
from
766a8db to
b8f6202
Compare
thomas-nguy
force-pushed
the
thomas/adr-007-implementation
branch
from
b8f6202 to
a8702d7
Compare
thomas-nguy
commented
Sep 5, 2022
| event __CronosSendToIbc(address sender, string recipient, uint256 amount); | ||
| event __CronosSendToChain(address sender, address recipient, uint256 amount, uint256 bridge_fee, uint256 chain_id); | ||
| event __CronosCancelSendToChain(address sender, uint256 id); | ||
| event __CronosSendToIbc(address sender, string recipient, uint256 amount, string channel_id, bytes extraData); |
There was a problem hiding this comment.
Will support indexed params in another PR. This is quite a big change.
thomas-nguy
force-pushed
the
thomas/adr-007-implementation
branch
from
a8702d7 to
c629384
Compare
JayT106
reviewed
Sep 6, 2022
| recipient := unpacked[1].(string) | ||
| amount := sdk.NewIntFromBigInt(unpacked[2].(*big.Int)) | ||
| // channelId := unpacked[3].(string) | ||
| // extraData := unpacked[4].([]byte) |
There was a problem hiding this comment.
why didn't we check/handle these 2 data? for the future use?
There was a problem hiding this comment.
arguments check is already handled by this line
unpacked, err := SendToIbcEventV2.Inputs.Unpack(data)
this is a comment to help for future use
thomas-nguy
force-pushed
the
thomas/adr-007-implementation
branch
from
c30dff3 to
68ab0fe
Compare
tomtau
pushed a commit
to tomtau/cronos
that referenced
this pull request
Nov 23, 2022
13 tasks
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
Solution : Implement ADR-007
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)