Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: state streaming is not supported in old versions #700

Merged
merged 5 commits into from
Oct 6, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 19, 2022

Solution:

  • backport the feature to older version of cosmos-sdk
  • integrate the basic file streamer to cronos, further processing can be done based on that
$ cronosd start --trace --streamers file
...
$ check files under $CRONOS_HOME/data/file_streamer/

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang changed the title Problem: state streaming is supported in old versions Problem: state streaming is not supported in old versions Sep 19, 2022
app/config.go Show resolved Hide resolved
app/config.go Show resolved Hide resolved
go.mod Show resolved Hide resolved
@yihuang yihuang marked this pull request as ready for review September 23, 2022 00:46
@yihuang yihuang requested a review from a team as a code owner September 23, 2022 00:46
@yihuang yihuang requested review from JayT106 and thomas-nguy and removed request for a team September 23, 2022 00:46
Solution:
- backport the feature to older version of cosmos-sdk
- integration the basic file streamer, further processing can be done based on that
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we planning to upgrade to this version ?

@yihuang
Copy link
Collaborator Author

yihuang commented Oct 3, 2022

are we planning to upgrade to this version ?

Yeah, at least deploy to some nodes to get a copy of historical state change stream.

Copy link
Collaborator

@JayT106 JayT106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yihuang yihuang enabled auto-merge (squash) October 6, 2022 00:58
@yihuang yihuang merged commit 4dac22e into crypto-org-chain:release/v0.6.x Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants