Problem: state streaming is not supported in old versions #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
force-pushed
the
release/v0.8.x
branch
from
56d7f11
to
8954f87
Compare
yihuang
commented
Sep 23, 2022
tomtau
added a commit
to tomtau/chain-main
that referenced
this pull request
Sep 29, 2022
Solution: backported state streaming (+ grpc nil fix) to 0.44.x fork basic integration added based on crypto-org-chain/cronos#717
yihuang
requested review from
mmsqe and
leejw51crypto
and removed request for
a team
thomas-nguy
reviewed
Oct 6, 2022
CHANGELOG.md
Outdated
| @@ -7,6 +7,10 @@ | |||
| - [#693](https://github.com/crypto-org-chain/cronos/pull/693) Clear `From` field when building cosmos tx in `eth_sendTransaction`. | |||
| - [cronos#715](https://github.com/crypto-org-chain/cronos/pull/715) Add option `iavl-disable-fastnode` to disable iavl fastnode indexing migration, and enable `iavl-cache-size` to have effect on app (backport #714). | |||
|
|
|||
| ### Improvements | |||
|
|
|||
| \- [#717](https://github.com/crypto-org-chain/cronos/pull/717) Integrate file streamer to stream the states of legacy blocks. | |||
There was a problem hiding this comment.
Suggested change
| \- [#717](https://github.com/crypto-org-chain/cronos/pull/717) Integrate file streamer to stream the states of legacy blocks. | |
| - [#717](https://github.com/crypto-org-chain/cronos/pull/717) Integrate file streamer to stream the states of legacy blocks. |
mmsqe
approved these changes
Oct 6, 2022
thomas-nguy
reviewed
Oct 6, 2022
cmd/cronosd/cmd/root.go
Outdated
| @@ -146,6 +147,7 @@ func initRootCmd(rootCmd *cobra.Command, encodingConfig params.EncodingConfig) { | |||
| func addModuleInitFlags(startCmd *cobra.Command) { | |||
| crisis.AddModuleInitFlags(startCmd) | |||
| cronos.AddModuleInitFlags(startCmd) | |||
| startCmd.Flags().String(cronosclient.FlagStreamers, "", "Enable streamers, only file streamer is supported right now") | |||
There was a problem hiding this comment.
nitty picky but would it be better to support enum type there?
maybe ok for the backporting version
There was a problem hiding this comment.
There'll be a better configuration system for streamers in another PR in cosmos-sdk.
For this version I think we just need to generate the stream files, then convert to version db with some offline script.
Solution: - update iavl library to v0.19.4
yihuang
force-pushed
the
release/v0.8.x
branch
from
e2c59cb
to
084e4a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)