-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: dynamic-level-bytes is not enabled for restored application.db #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
JayT106,
calvinaco and
mmsqe
and removed request for
a team
March 3, 2023 07:48
Solution: - enable it on new db, but don't override existing db - another implication is, user can manually modify the OPTIONS file to tune the options that's not set by app
yihuang
commented
Mar 3, 2023
mmsqe
approved these changes
Mar 3, 2023
mmsqe
reviewed
Mar 3, 2023
yihuang
added a commit
that referenced
this pull request
Mar 3, 2023
…db (backport: #904) (#905) * Problem: dynamic-level-bytes is not enabled for restored application.db Solution: - enable it on new db, but don't override existing db - another implication is, user can manually modify the OPTIONS file to tune the options that's not set by app * remove flagsNumLevels * Update cmd/cronosd/opendb/opendb_rocksdb.go Signed-off-by: yihuang <huang@crypto.com> * deduplicate code * use upstream * fix build --------- Signed-off-by: yihuang <huang@crypto.com>
13 tasks
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #902
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)