Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: dynamic-level-bytes is not enabled for restored application.db #904

Merged
merged 5 commits into from
Mar 3, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Mar 3, 2023

Closes: #902

Solution:

  • enable it on new db, but don't override existing db
  • another implication is, user can manually modify the OPTIONS file to tune those options that's not set by app

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner March 3, 2023 07:48
@yihuang yihuang requested review from JayT106, calvinaco and mmsqe and removed request for a team March 3, 2023 07:48
Solution:
- enable it on new db, but don't override existing db
- another implication is, user can manually modify the OPTIONS file to tune the options that's not set by app
@yihuang yihuang added the backport/v1.0.x backport to release/v1.0.x label Mar 3, 2023
go.mod Outdated Show resolved Hide resolved
cmd/cronosd/opendb/opendb_rocksdb.go Show resolved Hide resolved
@yihuang yihuang enabled auto-merge (squash) March 3, 2023 08:49
@yihuang yihuang merged commit 2a8e2d4 into crypto-org-chain:main Mar 3, 2023
yihuang added a commit that referenced this pull request Mar 3, 2023
…db (backport: #904) (#905)

* Problem: dynamic-level-bytes is not enabled for restored application.db

Solution:
- enable it on new db, but don't override existing db
- another implication is, user can manually modify the OPTIONS file to tune the options that's not set by app

* remove flagsNumLevels

* Update cmd/cronosd/opendb/opendb_rocksdb.go

Signed-off-by: yihuang <huang@crypto.com>

* deduplicate code

* use upstream

* fix build

---------

Signed-off-by: yihuang <huang@crypto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v1.0.x backport to release/v1.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: db size is still not ideal
2 participants