cleanup

app/app.go

@@ -796,7 +796,7 @@ func NewEthermintApp(
  case srvconfig.BlockExecutorBlockSTM:
  sdk.SetAddrCacheEnabled(false)
  workers := cast.ToInt(appOpts.Get(srvflags.EVMBlockSTMWorkers))
- app.SetTxExecutor(STMTxExecutor(app.GetStoreKeys(), workers, app.EvmKeeper))
+ app.SetTxExecutor(STMTxExecutor(app.GetStoreKeys(), workers, true, app.EvmKeeper, txConfig.TxDecoder()))
  case "", srvconfig.BlockExecutorSequential:
  app.SetTxExecutor(DefaultTxExecutor)
  default:

app/executor.go

@@ -24,14 +24,14 @@ import (
 var EVMDenomForEstimation = evmtypes.DefaultEVMDenom
 
 func DefaultTxExecutor(_ context.Context,
- txs []sdk.Tx,
+ txs [][]byte,
  ms storetypes.MultiStore,
- deliverTxWithMultiStore func(int, storetypes.MultiStore, map[string]any) *abci.ExecTxResult,
+ deliverTxWithMultiStore func(int, sdk.Tx, storetypes.MultiStore, map[string]any) *abci.ExecTxResult,
 ) ([]*abci.ExecTxResult, error) {
  blockSize := len(txs)
  results := make([]*abci.ExecTxResult, blockSize)
  for i := 0; i < blockSize; i++ {
- results[i] = deliverTxWithMultiStore(i, ms, nil)
+ results[i] = deliverTxWithMultiStore(i, nil, ms, nil)
  }
  return evmtypes.PatchTxResponses(results), nil
 }
@@ -40,7 +40,13 @@ type evmKeeper interface {
  GetParams(ctx sdk.Context) evmtypes.Params
 }
 
-func STMTxExecutor(stores []storetypes.StoreKey, workers int, evmKeeper evmKeeper) baseapp.TxExecutor {
+func STMTxExecutor(
+ stores []storetypes.StoreKey,
+ workers int,
+ estimate bool,
+ evmKeeper evmKeeper,
+ txDecoder sdk.TxDecoder,
+) baseapp.TxExecutor {
  var authStore, bankStore int
  index := make(map[storetypes.StoreKey]int, len(stores))
  for i, k := range stores {
@@ -53,12 +59,12 @@ func STMTxExecutor(stores []storetypes.StoreKey, workers int, evmKeeper evmKeepe
  }
  return func(
  ctx context.Context,
- txs []sdk.Tx,
+ txs [][]byte,
  ms storetypes.MultiStore,
- deliverTxWithMultiStore func(int, storetypes.MultiStore, map[string]any) *abci.ExecTxResult,
+ deliverTxWithMultiStore func(int, sdk.Tx, storetypes.MultiStore, map[string]any) *abci.ExecTxResult,
  ) ([]*abci.ExecTxResult, error) {
  blockSize := len(txs)
- if len(txs) == 0 {
+ if blockSize == 0 {
  return nil, nil
  }
  results := make([]*abci.ExecTxResult, blockSize)
@@ -68,9 +74,21 @@ func STMTxExecutor(stores []storetypes.StoreKey, workers int, evmKeeper evmKeepe
  incarnationCache[i].Store(&m)
  }
 
- // pre-estimation
- evmDenom := evmKeeper.GetParams(sdk.NewContext(ms, cmtproto.Header{}, false, log.NewNopLogger())).EvmDenom
- estimates := preEstimates(txs, authStore, bankStore, evmDenom)
+ var (
+ memTxs []sdk.Tx
+ estimates map[int]blockstm.MultiLocations
+ )
+ if estimate {
+ memTxs = make([]sdk.Tx, len(txs))
+ for i, rawTx := range txs {
+ if memTx, err := txDecoder(rawTx); err == nil {
+ memTxs[i] = memTx
+ }
+ }
+ // pre-estimation
+ evmDenom := evmKeeper.GetParams(sdk.NewContext(ms, cmtproto.Header{}, false, log.NewNopLogger())).EvmDenom
+ estimates = preEstimates(memTxs, authStore, bankStore, evmDenom)
+ }
 
  if err := blockstm.ExecuteBlockWithEstimates(
  ctx,
@@ -89,8 +107,7 @@ func STMTxExecutor(stores []storetypes.StoreKey, workers int, evmKeeper evmKeepe
  cache = *v
  }
 
- result := deliverTxWithMultiStore(int(txn), msWrapper{ms}, cache)
- results[txn] = result
+ results[txn] = deliverTxWithMultiStore(int(txn), memTxs[txn], msWrapper{ms}, cache)
 
  if v != nil {
  incarnationCache[txn].Store(v)

go.mod

@@ -29,7 +29,7 @@ require (
  github.com/cosmos/ibc-go/modules/capability v1.0.0
  github.com/cosmos/ibc-go/v8 v8.1.0
  github.com/cosmos/rosetta v0.50.3-1
- github.com/crypto-org-chain/go-block-stm v0.0.0-20240806075927-09a64748f883
+ github.com/crypto-org-chain/go-block-stm v0.0.0-20240911081142-92839e79a3ae
  github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc
  github.com/ethereum/go-ethereum v1.10.26
  github.com/gogo/protobuf v1.3.2
@@ -243,17 +243,16 @@ require (
 
 replace (
  // release/v0.50.x
- cosmossdk.io/client/v2 => github.com/crypto-org-chain/cosmos-sdk/client/v2 v2.0.0-20240722033504-50f1fa0c49d1
- cosmossdk.io/store => github.com/crypto-org-chain/cosmos-sdk/store v0.0.0-20240722033504-50f1fa0c49d1
- cosmossdk.io/x/tx => github.com/crypto-org-chain/cosmos-sdk/x/tx v0.0.0-20240722033504-50f1fa0c49d1
- github.com/cosmos/cosmos-sdk => github.com/yihuang/cosmos-sdk v0.43.0-beta1.0.20240911025848-f57522de4210
+ cosmossdk.io/client/v2 => github.com/crypto-org-chain/cosmos-sdk/client/v2 v2.0.0-20240911084450-6870ba130be2
+ cosmossdk.io/store => github.com/crypto-org-chain/cosmos-sdk/store v0.0.0-20240911084450-6870ba130be2
+ cosmossdk.io/x/tx => github.com/crypto-org-chain/cosmos-sdk/x/tx v0.0.0-20240911084450-6870ba130be2
+ github.com/cosmos/cosmos-sdk => github.com/crypto-org-chain/cosmos-sdk v0.50.6-0.20240911084450-6870ba130be2
 )
 
 replace (
  // use cosmos keyring
  github.com/99designs/keyring => github.com/cosmos/keyring v1.2.0
  github.com/cockroachdb/pebble => github.com/cockroachdb/pebble v0.0.0-20230209160836-829675f94811
- github.com/crypto-org-chain/go-block-stm => github.com/yihuang/go-block-stm v0.0.0-20240911061126-1f831176379f
  // release/v1.11.x
  github.com/ethereum/go-ethereum => github.com/crypto-org-chain/go-ethereum v1.10.20-0.20240425065928-ebb09502e7a7
  // Fix upstream GHSA-h395-qcrw-5vmq vulnerability.

go.sum

@@ -411,12 +411,16 @@ github.com/creack/pty v1.1.7/go.mod h1:lj5s0c3V2DBrqTV7llrYr5NG6My20zk30Fl46Y7Do
 github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
 github.com/crypto-org-chain/btree v0.0.0-20240406140148-2687063b042c h1:MOgfS4+FBB8cMkDE2j2VBVsbY+HCkPIu0YsJ/9bbGeQ=
 github.com/crypto-org-chain/btree v0.0.0-20240406140148-2687063b042c/go.mod h1:twD9XRA5jj9VUQGELzDO4HPQTNJsoWWfYEL+EUQ2cKY=
-github.com/crypto-org-chain/cosmos-sdk/client/v2 v2.0.0-20240722033504-50f1fa0c49d1 h1:zqTYZqMKnv15UkKwCEbGqshZ6tWczctBYP53FxmEiF8=
-github.com/crypto-org-chain/cosmos-sdk/client/v2 v2.0.0-20240722033504-50f1fa0c49d1/go.mod h1:W5sR4asmVDUhJpEmuXTUBkk/yEefKlXTjVWcNciVSR0=
-github.com/crypto-org-chain/cosmos-sdk/store v0.0.0-20240722033504-50f1fa0c49d1 h1:ZlezTiQu9pYpVO+6sB9+W3fvthIpV1GgSI8kPjw+v5s=
-github.com/crypto-org-chain/cosmos-sdk/store v0.0.0-20240722033504-50f1fa0c49d1/go.mod h1:gjE3DZe4t/+VeIk6CmrouyqiuDbZ7QOVDDq3nLqBTpg=
-github.com/crypto-org-chain/cosmos-sdk/x/tx v0.0.0-20240722033504-50f1fa0c49d1 h1:r0ALP31Wnw19FqEmqzsK2SFNqdMetHshnM/X/FeJRIo=
-github.com/crypto-org-chain/cosmos-sdk/x/tx v0.0.0-20240722033504-50f1fa0c49d1/go.mod h1:RTiTs4hkXG6IvYGknvB8p79YgjYJdcbzLUOGJChsPnY=
+github.com/crypto-org-chain/cosmos-sdk v0.50.6-0.20240911084450-6870ba130be2 h1:4SoAvnxDaiIWcgm6XOmPDIdCf4/WNhNYLXGbij1eaA0=
+github.com/crypto-org-chain/cosmos-sdk v0.50.6-0.20240911084450-6870ba130be2/go.mod h1:Rb43DdB0i/rKcCN69Tg2X3+zA4WhJ7MC8K3a6Ezh38E=
+github.com/crypto-org-chain/cosmos-sdk/client/v2 v2.0.0-20240911084450-6870ba130be2 h1:5oGZtOUcauk9dtv+8BCfj2PEQyXEEEV+K3sP4OSvBmg=
+github.com/crypto-org-chain/cosmos-sdk/client/v2 v2.0.0-20240911084450-6870ba130be2/go.mod h1:W5sR4asmVDUhJpEmuXTUBkk/yEefKlXTjVWcNciVSR0=
+github.com/crypto-org-chain/cosmos-sdk/store v0.0.0-20240911084450-6870ba130be2 h1:CGh5I0L6IYhe0AJevb4vf5TE3ru+qAgMs437BlWCwo8=
+github.com/crypto-org-chain/cosmos-sdk/store v0.0.0-20240911084450-6870ba130be2/go.mod h1:gjE3DZe4t/+VeIk6CmrouyqiuDbZ7QOVDDq3nLqBTpg=
+github.com/crypto-org-chain/cosmos-sdk/x/tx v0.0.0-20240911084450-6870ba130be2 h1:mxlOSCru7YgmX055rrlkCSUu0D8lAqJ8Dnhp0yXCBuM=
+github.com/crypto-org-chain/cosmos-sdk/x/tx v0.0.0-20240911084450-6870ba130be2/go.mod h1:RTiTs4hkXG6IvYGknvB8p79YgjYJdcbzLUOGJChsPnY=
+github.com/crypto-org-chain/go-block-stm v0.0.0-20240911081142-92839e79a3ae h1:gakWYsVubWX8P9NpxaPnvg0UJYfIZigfko5WN57t7OA=
+github.com/crypto-org-chain/go-block-stm v0.0.0-20240911081142-92839e79a3ae/go.mod h1:iwQTX9xMX8NV9k3o2BiWXA0SswpsZrDk5q3gA7nWYiE=
 github.com/crypto-org-chain/go-ethereum v1.10.20-0.20240425065928-ebb09502e7a7 h1:V43F3JFcqG4MUThf9W/DytnPblpR6CcaLBw2Wx6zTgE=
 github.com/crypto-org-chain/go-ethereum v1.10.20-0.20240425065928-ebb09502e7a7/go.mod h1:+a8pUj1tOyJ2RinsNQD4326YS+leSoKGiG/uVVb0x6Y=
 github.com/danieljoos/wincred v1.2.0 h1:ozqKHaLK0W/ii4KVbbvluM91W2H3Sh0BncbUNPS7jLE=
@@ -1127,10 +1131,6 @@ github.com/xiang90/probing v0.0.0-20190116061207-43a291ad63a2/go.mod h1:UETIi67q
 github.com/xordataexchange/crypt v0.0.3-0.20170626215501-b2862e3d0a77/go.mod h1:aYKd//L2LvnjZzWKhF00oedf4jCCReLcmhLdhm1A27Q=
 github.com/xrash/smetrics v0.0.0-20201216005158-039620a65673 h1:bAn7/zixMGCfxrRTfdpNzjtPYqr8smhKouy9mxVdGPU=
 github.com/xrash/smetrics v0.0.0-20201216005158-039620a65673/go.mod h1:N3UwUGtsrSj3ccvlPHLoLsHnpR27oXr4ZE984MbSER8=
-github.com/yihuang/cosmos-sdk v0.43.0-beta1.0.20240911025848-f57522de4210 h1:nIoK3o8/p8BRcYvpN9VyY3CAhyVuw5TH2HN3OPYoXAQ=
-github.com/yihuang/cosmos-sdk v0.43.0-beta1.0.20240911025848-f57522de4210/go.mod h1:Rb43DdB0i/rKcCN69Tg2X3+zA4WhJ7MC8K3a6Ezh38E=
-github.com/yihuang/go-block-stm v0.0.0-20240911061126-1f831176379f h1:G17UpSucfm3SPCXdkJMrsAXJyXDJHsD5zWiQ6GUCwZ4=
-github.com/yihuang/go-block-stm v0.0.0-20240911061126-1f831176379f/go.mod h1:iwQTX9xMX8NV9k3o2BiWXA0SswpsZrDk5q3gA7nWYiE=
 github.com/yuin/goldmark v1.1.25/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
 github.com/yuin/goldmark v1.1.27/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
 github.com/yuin/goldmark v1.1.32/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=

gomod2nix.toml

@@ -20,7 +20,7 @@ schema = 3
  version = "v0.7.5"
  hash = "sha256-Nuw697sJr56kU3EU7DV1eYNkyI76psznIVqYAV6RfbQ="
  [mod."cosmossdk.io/client/v2"]
- version = "v2.0.0-20240722033504-50f1fa0c49d1"
+ version = "v2.0.0-20240911084450-6870ba130be2"
  hash = "sha256-60hmufv3Ml4Pv3zNwgn8eeqlEINOR6n9MKr2QHddoxo="
  replaced = "github.com/crypto-org-chain/cosmos-sdk/client/v2"
  [mod."cosmossdk.io/collections"]
@@ -42,7 +42,7 @@ schema = 3
  version = "v1.3.0"
  hash = "sha256-EEFK43Cr0g0ndhQhkIKher0FqV3mvkmE9z0sP7uVSHg="
  [mod."cosmossdk.io/store"]
- version = "v0.0.0-20240722033504-50f1fa0c49d1"
+ version = "v0.0.0-20240911084450-6870ba130be2"
  hash = "sha256-Dm3sSZNJBcnBF33PULoTpK4rkNQbsZl0DfTqH1GPCQM="
  replaced = "github.com/crypto-org-chain/cosmos-sdk/store"
  [mod."cosmossdk.io/tools/confix"]
@@ -55,7 +55,7 @@ schema = 3
  version = "v0.1.0"
  hash = "sha256-/gWvrqvy6bW90+NU66T+9QysYgvG1VbwfYJZ8tkqpeA="
  [mod."cosmossdk.io/x/tx"]
- version = "v0.0.0-20240722033504-50f1fa0c49d1"
+ version = "v0.0.0-20240911084450-6870ba130be2"
  hash = "sha256-xT5IdapEx1h46ofBpxcBQfzGF2EntmC8xZl7aym/6xE="
  replaced = "github.com/crypto-org-chain/cosmos-sdk/x/tx"
  [mod."cosmossdk.io/x/upgrade"]
@@ -163,9 +163,9 @@ schema = 3
  version = "v1.0.0-beta.5"
  hash = "sha256-Fy/PbsOsd6iq0Njy3DVWK6HqWsogI+MkE8QslHGWyVg="
  [mod."github.com/cosmos/cosmos-sdk"]
- version = "v0.43.0-beta1.0.20240911025848-f57522de4210"
- hash = "sha256-PSGl0bJk3yxkFVnBWm0ZaTz2PzxqXxkyRlotpG1Ah+M="
- replaced = "github.com/yihuang/cosmos-sdk"
+ version = "v0.50.6-0.20240911084450-6870ba130be2"
+ hash = "sha256-kl2sLe8vITIguRGtdeviDeP3R5JIbRg+eDsheGd4PqM="
+ replaced = "github.com/crypto-org-chain/cosmos-sdk"
  [mod."github.com/cosmos/go-bip39"]
  version = "v1.0.0"
  hash = "sha256-Qm2aC2vaS8tjtMUbHmlBSagOSqbduEEDwc51qvQaBmA="
@@ -203,9 +203,8 @@ schema = 3
  version = "v0.0.24"
  hash = "sha256-4vUukHONOjNn0qfQr4esK6TWfPWsIp+rbdz65og84lw="
  [mod."github.com/crypto-org-chain/go-block-stm"]
- version = "v0.0.0-20240911061126-1f831176379f"
- hash = "sha256-lKkKqz9yb1Yto/TgTqTdFVIjUY6LlKM0knRqI1ne9Bg="
- replaced = "github.com/yihuang/go-block-stm"
+ version = "v0.0.0-20240911081142-92839e79a3ae"
+ hash = "sha256-8MhSeC5BB5BwOet3k3Rfua0TBeBATtLSwaW6s5WpYCM="
  [mod."github.com/danieljoos/wincred"]
  version = "v1.2.0"
  hash = "sha256-LHcvTJCc8++bFndbd8ZgMSTe4L5h2C4rN+cSWHCz54Y="