Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message in SendTransaction json-rpc api #17

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Nov 26, 2021

Description

Solution:

Remove stacktrace.Propagates, and recover error message in jsonrpc server


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang force-pushed the error-message-backport branch 3 times, most recently from 8c493c1 to a914ccb Compare November 26, 2021 05:07
Closes: evmos#785

Solution:
- Remove `stacktrace.Propagate`s, and recover error message in jsonrpc server

changelog

fix error messages
@yihuang yihuang force-pushed the error-message-backport branch from a914ccb to 1be3686 Compare November 26, 2021 05:08
@thomas-nguy
Copy link
Collaborator

lgtm otherwise

@yihuang yihuang merged commit 839e6b4 into crypto-org-chain:master Nov 29, 2021
@yihuang yihuang deleted the error-message-backport branch November 29, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants