Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align empty account result for old blocks as ethereum (backport: #1484) #221

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Mar 14, 2023

for more evmos#1484

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* align result account as ethereum

* add test_get_transaction_count

* add change doc

* sync gomod2nix

* Apply suggestions from code review

* crosscheck with ws & geth

* sync gomod2nix

* Update rpc/backend/utils.go

* use session provider

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #221 (e706062) into release/v0.20.x-cronos (44a41ad) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           release/v0.20.x-cronos     #221      +/-   ##
==========================================================
- Coverage                   57.35%   57.31%   -0.04%     
==========================================================
  Files                         108      108              
  Lines                       10090    10096       +6     
==========================================================
  Hits                         5787     5787              
- Misses                       4057     4063       +6     
  Partials                      246      246              
Impacted Files Coverage Δ
rpc/backend/utils.go 8.67% <0.00%> (-0.32%) ⬇️

@mmsqe mmsqe requested a review from yihuang March 14, 2023 04:07
@mmsqe mmsqe merged commit 48c2a72 into crypto-org-chain:release/v0.20.x-cronos Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants