Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: backport proto script and btcd fix (backport: #1466 #1716) #255

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jun 13, 2023

for more info: evmos#1466 evmos#1716

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

MalteHerrmann and others added 2 commits June 13, 2023 12:09
* Delete local copy of third party proto files

* Update protocgen script and buf yaml files to mirror cosmos-sdk

* Update makefile commands for proto-gen and proto-swagger-gen to correctly use docker

* Commit changed .pb.go files after updating the protogen scripts

* Adjust grep in proto-tools-installer script to look for correct gogoproto replacement

* address reviews - remove unnecessary ignore in buf.yaml and cosmos-sdk download in the protocgen script

* remove proto-update-deps from makefile as we don't store local copies of third party protofiles anymore

* Add changelog entry

* Update protoc-swagger-gen.sh

* Remove third party queries from swagger-ui config (for now)

* fix integrations tests

* fix dead changelog links (markdown-link-check)

Co-authored-by: Freddy Caceres <facs95@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
* bump btcd for security fix

Solution:
- update cosmos-sdk to 0.46.11
- bump btcd

* remove go-ethereum-hdwallet dependency

* gomod2nix

* miss file
@mmsqe mmsqe requested a review from yihuang June 13, 2023 04:21
@mmsqe mmsqe changed the title deps: backport proto script and btcd fix deps: backport proto script and btcd fix (backport: #1466 #1716) Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #255 (3353750) into release/v0.20.x-cronos (0ea7b86) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           release/v0.20.x-cronos     #255      +/-   ##
==========================================================
- Coverage                   52.56%   52.52%   -0.04%     
==========================================================
  Files                         113      113              
  Lines                       11073    11091      +18     
==========================================================
+ Hits                         5820     5826       +6     
- Misses                       5006     5017      +11     
- Partials                      247      248       +1     
Impacted Files Coverage Δ
rpc/namespaces/ethereum/eth/filters/api.go 0.00% <0.00%> (ø)
x/evm/types/utils.go 62.16% <30.76%> (-10.57%) ⬇️

@mmsqe mmsqe marked this pull request as ready for review June 13, 2023 04:55
@mmsqe mmsqe closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants