Problem: no interface to set the chain config for precompile contract #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmsqe
commented
Nov 23, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
x/evm/keeper/state_transition.go
Outdated
| @@ -357,6 +363,16 @@ | |||
| } | |||
|
|
|||
| evm := k.NewEVM(ctx, msg, cfg, tracer, stateDB, k.customContracts) | |||
| contractCreation := msg.To() == nil | |||
| time := uint64(ctx.BlockHeader().Time.Unix()) | |||
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
mmsqe
force-pushed
the
precompile_cfg
branch
from
2c89a43 to
0c06bfd
Compare
yihuang
approved these changes
Nov 30, 2023
dongsam
added a commit
to b-harvest/ethermint
that referenced
this pull request
Jun 4, 2024
- (evm) crypto-org-chain#328 Support precompile interface. - (statedb) crypto-org-chain#333 Support native action in statedb, prepare for precompiles. - (precompile) crypto-org-chain#338 Fix simulation of precompile using context. - (precompile) crypto-org-chain#342 Problem: native action don't support mem keys - (precompile) crypto-org-chain#343 Problem: no api to convert native events to logs - (precompile) crypto-org-chain#344 Fix error handling in precompile context. - (precompile) crypto-org-chain#346 Add support for new precompile context. - (precompile) crypto-org-chain#347 Problem: miss contract in ExtStateDB interface - (precompile) crypto-org-chain#359 Problem: no efficient way to execute read-only native actions - (precompile) crypto-org-chain#371 Add StateDB itself into native context for precompiles to emit evm logs directly. - (precompile) crypto-org-chain#380 Allow init precompiled contract with rules when new evm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)