Problem: sdk 0.50 is not used #407
Conversation
yes, still downloading docker images. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if err != nil { | ||
| return nil, err | ||
| if len(portPool) == 0 { | ||
| return nil, fmt.Errorf("failed to get port for API server") |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: trailofbits.go.missing-unlock-before-return.missing-unlock-before-return Error test
| if err != nil { | ||
| return nil, err | ||
| if len(portPool) == 0 { | ||
| return nil, fmt.Errorf("failed to get port for RPC server") |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: trailofbits.go.missing-unlock-before-return.missing-unlock-before-return Error test
| if err != nil { | ||
| return nil, err | ||
| if len(portPool) == 0 { | ||
| return nil, fmt.Errorf("failed to get port for GRPC server") |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: trailofbits.go.missing-unlock-before-return.missing-unlock-before-return Error test
| if err != nil { | ||
| return nil, err | ||
| if len(portPool) == 0 { | ||
| return nil, fmt.Errorf("failed to get port for JSON-RPC server") |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: trailofbits.go.missing-unlock-before-return.missing-unlock-before-return Error test
| if err != nil { | ||
| return nil, err | ||
| if len(portPool) == 0 { | ||
| return nil, fmt.Errorf("failed to get port for Proxy server") |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: trailofbits.go.missing-unlock-before-return.missing-unlock-before-return Error test
| if err != nil { | ||
| return nil, err | ||
| if len(portPool) == 0 { | ||
| return nil, fmt.Errorf("failed to get port for Proxy server") |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: trailofbits.go.missing-unlock-before-return.missing-unlock-before-return Error test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #407 +/- ##
===========================================
- Coverage 62.85% 62.53% -0.32%
===========================================
Files 130 130
Lines 12361 12495 +134
===========================================
+ Hits 7769 7814 +45
- Misses 4064 4135 +71
- Partials 528 546 +18
|
| @@ -92,7 +92,7 @@ | |||
| return nil, err | |||
| } | |||
|
|
|||
| go s.start(&s.wg, chHeaders, chTx, chLogs) | |||
| go s.start(&s.wg, chBlocks, chTx, chLogs) | |||
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
| store := k.storeService.OpenKVStore(ctx) | ||
| bz, err := store.Get(types.ParamsKey) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| func (am AppModule) BeginBlock(ctx sdk.Context, req abci.RequestBeginBlock) { | ||
| am.keeper.BeginBlock(ctx, req) | ||
| func (am AppModule) BeginBlock(ctx context.Context) error { | ||
| return am.keeper.BeginBlock(sdk.UnwrapSDKContext(ctx)) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| func (am AppModule) BeginBlock(ctx sdk.Context, req abci.RequestBeginBlock) { | ||
| am.keeper.BeginBlock(ctx, req) | ||
| func (am AppModule) BeginBlock(ctx context.Context) error { | ||
| return am.keeper.BeginBlock(sdk.UnwrapSDKContext(ctx)) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| am.keeper.EndBlock(ctx, req) | ||
| return []abci.ValidatorUpdate{} | ||
| func (am AppModule) EndBlock(ctx context.Context) error { | ||
| return am.keeper.EndBlock(sdk.UnwrapSDKContext(ctx)) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| for _, m := range app.ModuleManager.Modules { | ||
| if moduleWithName, ok := m.(module.HasName); ok { | ||
| moduleName := moduleWithName.Name() | ||
| if appModule, ok := moduleWithName.(appmodule.AppModule); ok { | ||
| modules[moduleName] = appModule | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
fix dependencies fix build upgrade protogen image Co-authored-by: mmsqe <mavis@crypto.com> wait for block properly fix py-lint fix test fix py-lint
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)