Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: invalid chain id for signer #501

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jul 24, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe requested a review from yihuang July 24, 2024 01:24
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.55%. Comparing base (d874df7) to head (e295477).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #501   +/-   ##
========================================
  Coverage    61.55%   61.55%           
========================================
  Files          128      128           
  Lines         9496     9499    +3     
========================================
+ Hits          5845     5847    +2     
- Misses        3111     3112    +1     
  Partials       540      540           
Files Coverage Δ
x/evm/keeper/keeper.go 86.08% <100.00%> (+0.24%) ⬆️
app/app.go 76.29% <0.00%> (-0.14%) ⬇️

@mmsqe mmsqe merged commit f3e62cb into crypto-org-chain:develop Jul 24, 2024
38 of 39 checks passed
@yihuang yihuang deleted the fix_chain_id branch July 24, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants