Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: default headerHashNum is too large #539

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Problem: default headerHashNum is too large #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
644545b
clean up
mmsqe Oct 7, 2024
0f785a6
Problem: default headerHashNum is too large
mmsqe Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions x/evm/types/msg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,3 @@ func (m *MsgUpdateParams) ValidateBasic() error {

return m.Params.Validate()
}

// GetSignBytes implements the LegacyMsg interface.
func (m MsgUpdateParams) GetSignBytes() []byte {
return sdk.MustSortJSON(AminoCdc.MustMarshalJSON(&m))
}
2 changes: 1 addition & 1 deletion x/evm/types/params.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ var (
// DefaultEnableCall enables contract calls (i.e true)
DefaultEnableCall = true
// DefaultHeaderHashNum defines the default number of header hash to persist.
DefaultHeaderHashNum = uint64(10000)
mmsqe marked this conversation as resolved.
Show resolved Hide resolved
DefaultHeaderHashNum = uint64(256)
)

// NewParams creates a new Params instance
Expand Down
11 changes: 0 additions & 11 deletions x/feemarket/types/msg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@ import (

var _ sdk.Msg = &MsgUpdateParams{}

// GetSigners returns the expected signers for a MsgUpdateParams message.
func (m *MsgUpdateParams) GetSigners() []sdk.AccAddress {
addr := sdk.MustAccAddressFromBech32(m.Authority)
return []sdk.AccAddress{addr}
}

// ValidateBasic does a sanity check of the provided data
func (m *MsgUpdateParams) ValidateBasic() error {
if _, err := sdk.AccAddressFromBech32(m.Authority); err != nil {
Expand All @@ -21,8 +15,3 @@ func (m *MsgUpdateParams) ValidateBasic() error {

return m.Params.Validate()
}

// GetSignBytes implements the LegacyMsg interface.
func (m MsgUpdateParams) GetSignBytes() []byte {
return sdk.MustSortJSON(AminoCdc.MustMarshalJSON(&m))
}
Loading