Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: sdk 0.52 is not used #568

Draft
wants to merge 76 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
dad369b
rm ibc (to be reverted)
mmsqe Dec 20, 2024
f47318f
cleanup cmd
mmsqe Dec 20, 2024
5d72070
avoid port conflicts on 26667
mmsqe Dec 20, 2024
94f30cb
coin type
mmsqe Dec 20, 2024
bfb8c8f
mod
mmsqe Dec 19, 2024
fa394ed
RegisterLegacyAminoCodec
mmsqe Dec 19, 2024
0e5979a
gogoprotoany
mmsqe Dec 19, 2024
c0b3c68
VerifyAddressFormat
mmsqe Dec 20, 2024
355098b
app
mmsqe Dec 19, 2024
a0f3f8c
RegisterLegacyAminoCodec
mmsqe Dec 19, 2024
35d058d
MkAccKeyOutput
mmsqe Dec 19, 2024
b41d08b
TxResults
mmsqe Dec 19, 2024
e318f15
WithBlockTime
mmsqe Dec 19, 2024
9d0ef04
GetHistoricalInfo
mmsqe Dec 19, 2024
dbfb4e6
burn
mmsqe Dec 19, 2024
3b6fd8f
GetSignerAcc
mmsqe Dec 19, 2024
5ef42aa
simulation
mmsqe Dec 19, 2024
9b6fda4
node
mmsqe Dec 19, 2024
84946d8
GetFullBIP44Path
mmsqe Dec 19, 2024
af37488
ante
mmsqe Dec 19, 2024
1b6364b
NewDynamicFeeChecker
mmsqe Dec 19, 2024
0f9c7f0
CacheWrapWithTrace
mmsqe Dec 19, 2024
5c2894b
export
mmsqe Dec 19, 2024
8bba0ef
upgrade
mmsqe Dec 19, 2024
b3cf348
cmd
mmsqe Dec 20, 2024
c1dbe07
InterfaceRegistrar
mmsqe Dec 20, 2024
1b00a65
app
mmsqe Dec 20, 2024
b9235f0
addressCodec
mmsqe Dec 20, 2024
58314ff
signing options not provided
mmsqe Dec 20, 2024
c122007
initGenesis
mmsqe Dec 20, 2024
008c389
ctx
mmsqe Dec 20, 2024
edcc709
protoTxProvider
mmsqe Dec 20, 2024
5be1e07
cointype
mmsqe Dec 20, 2024
0d19829
verifyIsOnCurve
mmsqe Dec 30, 2024
5e3837a
legacy params
mmsqe Dec 31, 2024
2a05077
disable blk meter
mmsqe Dec 31, 2024
cfc963c
UnorderedTxDecorator
mmsqe Dec 31, 2024
e154bce
mockMeter
mmsqe Dec 31, 2024
c24449f
fix test
mmsqe Dec 31, 2024
b38b8f0
check empty
mmsqe Dec 31, 2024
10ca66a
any
mmsqe Dec 31, 2024
aa9884c
fix test
mmsqe Dec 31, 2024
e076abf
check account
mmsqe Dec 31, 2024
0079579
fix height
mmsqe Dec 31, 2024
b927c81
avoid creating baseaccount
mmsqe Jan 2, 2025
5f8096e
decode tx: empty address string is not allowed
mmsqe Jan 2, 2025
0eaa7e6
fix test
mmsqe Jan 2, 2025
2187e3e
empty eip712 pubkey
mmsqe Jan 2, 2025
81d459b
gasmeter
mmsqe Jan 2, 2025
0a42d0a
Merge remote-tracking branch 'origin/develop' into bump_sdk
mmsqe Jan 2, 2025
dea6eea
deps
mmsqe Jan 2, 2025
e71a992
fix prefix
mmsqe Jan 3, 2025
9d3372e
setup
mmsqe Jan 3, 2025
aa9f9bc
bench
mmsqe Jan 3, 2025
75eac15
integration
mmsqe Jan 3, 2025
284abf8
DefaultConsensusParams
mmsqe Jan 3, 2025
c45c26d
migration
mmsqe Jan 3, 2025
dc25863
EnsureExists
mmsqe Jan 3, 2025
8ba6a18
no GetBaseDenom
mmsqe Jan 3, 2025
9ccfe2c
header
mmsqe Jan 3, 2025
2682d33
create acc
mmsqe Jan 3, 2025
0592b3a
fix keys
mmsqe Jan 3, 2025
93a978e
time
mmsqe Jan 3, 2025
a562740
fix multisig
mmsqe Jan 3, 2025
ed2ebe0
fix upgrade
mmsqe Jan 3, 2025
d0322d2
sim
mmsqe Jan 3, 2025
86391b2
event lint
mmsqe Jan 6, 2025
8a529a3
lint
mmsqe Jan 6, 2025
e5d5c69
compare hash
mmsqe Jan 6, 2025
50ffbaf
RandomAccounts
mmsqe Jan 6, 2025
b96b758
GetBondDenom
mmsqe Jan 6, 2025
5af2028
rm upgrade mod
mmsqe Jan 6, 2025
4e8b39c
fix sim
mmsqe Jan 6, 2025
e691c34
skip check header
mmsqe Jan 8, 2025
361663b
skip
mmsqe Jan 8, 2025
ec0759a
historical info is beyond range
mmsqe Jan 8, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -367,37 +367,42 @@ test-solidity:

test-sim-nondeterminism:
@echo "Running non-determinism test..."
@go test -mod=readonly $(SIMAPP) -run TestAppStateDeterminism -Enabled=true \
@go test -tags=sims -mod=readonly $(SIMAPP) -run TestAppStateDeterminism -Enabled=true \
-NumBlocks=100 -BlockSize=200 -Commit=true -Period=0 -v -timeout 24h

test-sim-random-genesis-fast:
@echo "Running random genesis simulation..."
@go test -mod=readonly $(SIMAPP) -run TestFullAppSimulation \
@go test -tags=sims -mod=readonly $(SIMAPP) -run TestFullAppSimulation \
-Enabled=true -NumBlocks=100 -BlockSize=200 -Commit=true -Seed=99 -Period=5 -v -timeout 24h

test-sim-import-export: export GOFLAGS=-tags=sims
test-sim-import-export: runsim
@echo "Running application import/export simulation. This may take several minutes..."
@$(BINDIR)/runsim -Jobs=4 -SimAppPkg=$(SIMAPP) -ExitOnFail 50 5 TestAppImportExport

test-sim-after-import: export GOFLAGS=-tags=sims
test-sim-after-import: runsim
@echo "Running application simulation-after-import. This may take several minutes..."
@$(BINDIR)/runsim -Jobs=4 -SimAppPkg=$(SIMAPP) -ExitOnFail 50 5 TestAppSimulationAfterImport

test-sim-random-genesis-multi-seed: export GOFLAGS=-tags=sims
test-sim-random-genesis-multi-seed: runsim
@echo "Running multi-seed custom genesis simulation..."
@$(BINDIR)/runsim -SimAppPkg=$(SIMAPP) -ExitOnFail 400 5 TestFullAppSimulation

test-sim-multi-seed-long: export GOFLAGS=-tags=sims
test-sim-multi-seed-long: runsim
@echo "Running long multi-seed application simulation. This may take awhile!"
@$(BINDIR)/runsim -Jobs=4 -SimAppPkg=$(SIMAPP) -ExitOnFail 500 50 TestFullAppSimulation

test-sim-multi-seed-short: export GOFLAGS=-tags=sims
test-sim-multi-seed-short: runsim
@echo "Running short multi-seed application simulation. This may take awhile!"
@$(BINDIR)/runsim -Jobs=4 -SimAppPkg=$(SIMAPP) -ExitOnFail 50 10 TestFullAppSimulation

test-sim-benchmark-invariants:
@echo "Running simulation invariant benchmarks..."
@go test -mod=readonly $(SIMAPP) -benchmem -bench=BenchmarkInvariants -run=^$ \
@go test -tags=sims -mod=readonly $(SIMAPP) -benchmem -bench=BenchmarkInvariants -run=^$ \
-Enabled=true -NumBlocks=1000 -BlockSize=200 \
-Period=1 -Commit=true -Seed=57 -v -timeout 24h

Expand Down
20 changes: 8 additions & 12 deletions app/ante/ante.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@
"fmt"
"runtime/debug"

"cosmossdk.io/core/gas"
tmlog "cosmossdk.io/log"

errorsmod "cosmossdk.io/errors"
storetypes "cosmossdk.io/store/types"
"github.com/cosmos/cosmos-sdk/crypto/types/multisig"
sdk "github.com/cosmos/cosmos-sdk/types"
errortypes "github.com/cosmos/cosmos-sdk/types/errors"
Expand All @@ -34,9 +34,7 @@
"github.com/evmos/ethermint/crypto/ethsecp256k1"
)

const (
secp256k1VerifyCost uint64 = 21000
)
const Secp256k1VerifyCost uint64 = 21000

// NewAnteHandler returns an ante handler responsible for attempting to route an
// Ethereum or SDK transaction to an internal ante handler for performing
Expand All @@ -59,9 +57,9 @@
// disable vesting message types
for _, msg := range tx.GetMsgs() {
switch msg.(type) {
case *vestingtypes.MsgCreateVestingAccount,
*vestingtypes.MsgCreatePeriodicVestingAccount,
*vestingtypes.MsgCreatePermanentLockedAccount:
case *vestingtypes.BaseVestingAccount,
*vestingtypes.PermanentLockedAccount,
*vestingtypes.PeriodicVestingAccount:

Check warning on line 62 in app/ante/ante.go

View check run for this annotation

Codecov / codecov/patch

app/ante/ante.go#L62

Added line #L62 was not covered by tests
return ctx, errorsmod.Wrapf(
errortypes.ErrInvalidRequest,
"vesting messages are not supported",
Expand Down Expand Up @@ -131,14 +129,12 @@
// for signature verification based upon the public key type. The cost is fetched from the given params and is matched
// by the concrete type.
func DefaultSigVerificationGasConsumer(
meter storetypes.GasMeter, sig signing.SignatureV2, params authtypes.Params,
meter gas.Meter, sig signing.SignatureV2, params authtypes.Params,
) error {
pubkey := sig.PubKey
switch pubkey := pubkey.(type) {
case *ethsecp256k1.PubKey:
meter.ConsumeGas(secp256k1VerifyCost, "ante verify: eth_secp256k1")
return nil

return meter.Consume(Secp256k1VerifyCost, "ante verify: eth_secp256k1")
case multisig.PubKey:
// Multisig keys
multisignature, ok := sig.Data.(*signing.MultiSignatureData)
Expand All @@ -154,7 +150,7 @@

// ConsumeMultisignatureVerificationGas consumes gas from a GasMeter for verifying a multisig pubkey signature
func ConsumeMultisignatureVerificationGas(
meter storetypes.GasMeter, sig *signing.MultiSignatureData, pubkey multisig.PubKey,
meter gas.Meter, sig *signing.MultiSignatureData, pubkey multisig.PubKey,
params authtypes.Params, accSeq uint64,
) error {
size := sig.BitArray.Count()
Expand Down
Loading
Loading