Problem: Ethers does not manually set gas limits in EIP1559 transactions (backport peggy#432) #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devashishdxt
approved these changes
Jul 13, 2022
thomas-nguy
changed the title
|
thanks for the review @devashishdxt @tomtau could we give devashish write access? |
|
@devashishdxt should have a write access now |
tomtau
reviewed
Jul 13, 2022
Comment on lines
207
to
+208
| let gas_price_as_f32 = downcast_to_f32(cost.gas_price).unwrap(); // if the total cost isn't greater, this isn't | ||
| let gas_as_f32 = downcast_to_f32(cost.gas).unwrap(); // same as above re: total cost |
There was a problem hiding this comment.
some of those fixed point number types in ethers have multiplication and other operations defined, so perhaps there's no need for this casting to floating points (which could make things behave strangely)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution : add a gas limit multiplier
Backport PeggyJV#432