Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide sensitive info mode #1170

Merged

Conversation

ben-kaufman
Copy link
Contributor

Add toolbar button to hide/ show "sensitive" information - like balances and data of txs and addresses.

@stepansnigirev stepansnigirev merged commit 92dfd71 into cryptoadvance:master May 21, 2021
@ben-kaufman ben-kaufman deleted the hide-sensitive-info-mode branch May 21, 2021 19:14
@relativisticelectron
Copy link
Collaborator

relativisticelectron commented Aug 12, 2022

I do not understand the reason why this hiding is useful. What threat model does it protect against?

  • Sparrow or electrum don't hide amounts. AFAIK no other software wallet does this. And hardware wallets do an automatic logout.
  • hiding everything makes specter unusable (except for receive addresses)... How should specter be used with hidden amounts?
  • if you want to hide amounts, then log out (auto-log-out is already implemented) or close the application, where you have optional password protection.
  • new users go panicky if suddenly nothing works any more and they don't know which button to press to make it visible again. I saw this happening, and it is not intuitive for users. This
    "autohide_sensitive_info_timeout_minutes": 20,
    should be "NEVER" by default

Tagging also @moneymanolis

@moneymanolis
Copy link
Collaborator

Let me look into that. I, personally, would also not enable it by default - at least without any proper notification on what is going on.

@stepansnigirev
Copy link
Contributor

I agree, should be never by default.

@relativisticelectron
Copy link
Collaborator

I do not understand the reason why this hiding is useful. What threat model does it protect against?

@ben-kaufman : can you please explain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants