Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Multiple send bug fixes #1538

Merged
merged 24 commits into from
Jan 28, 2022
Merged

Conversation

moneymanolis
Copy link
Collaborator

  • Multiple send bug fixes
  • Disabling RBF and subtract fee from for Liquid
  • Restoring Cypress tests

@moneymanolis moneymanolis requested a review from k9ert January 26, 2022 19:18
@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for specter-desktop-docs ready!

🔨 Explore the source changes: db9b65d

🔍 Inspect the deploy log: https://app.netlify.com/sites/specter-desktop-docs/deploys/61f3c84f02ae3b00072dfccc

😎 Browse the preview: https://deploy-preview-1538--specter-desktop-docs.netlify.app

@moneymanolis moneymanolis changed the title Bugfix: Multiple send bugfixes Bug fix: Multiple send bug fixes Jan 26, 2022
@k9ert k9ert requested a review from stepansnigirev January 27, 2022 17:15
@stepansnigirev
Copy link
Contributor

stepansnigirev commented Jan 27, 2022

Subtract from amount is not visible on Liquid. It looks like it gets enabled when I click on "Send max", but then I can't change it any more. Would be nice to see the checkbox if currently selected asset is LBTC.

image

@stepansnigirev
Copy link
Contributor

stepansnigirev commented Jan 27, 2022

If I make two outputs, on the first output I select to send max of my LBTC,
THEN in the second output I click on Send Max of my assets,
I get an error "insufficient funds"
I think it's because of some bug in subtract from amount logic - I assume when I click on send max on the asset output, the subtract checkbox gets unchecked on the first checkbox that send LBTC.
image

// Switch off RBF and subtract fee for Liquid
function adjustForLiquid() {
if (NETWORK == "Liquid") {
console.log("On Liquid, removing RBF and subtract from features ... ")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... ?

document.getElementById('subtract_from').style.display = 'block';
document.getElementById('subtract_from_input').value = i + 1;
}
FeeSelectionComponent.setSubtract(units[i] == 'sat' || units[i] == 'btc' || units[i] == 'lbtc');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember LBTC has unit btc or sat, so it will never be lbtc

@k9ert
Copy link
Contributor

k9ert commented Jan 28, 2022

Additional refinements will be resolved in further PRs.

@k9ert k9ert closed this Jan 28, 2022
@k9ert k9ert reopened this Jan 28, 2022
@k9ert k9ert merged commit c660e05 into cryptoadvance:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants