-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor logic + cleanup + bug fixes #160
Refactor logic + cleanup + bug fixes #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When broadcasting the transaction I get an error:
'Specter' object has no attribute 'wallets' in controller.py
line 70.
Otherwise ACK :)
@stepansnigirev thanks for testing, I've encountered it while continuing the refactoring too, I think now it should be fine. |
I think let's continue refactoring here. It would be nice to finish splitting device and wallet classes in this PR. |
LGTM so far. I was a bit concerned that renaming logic.py back to specter.py (which caused trouble in the past) would again cause trouble, but that doesn't seem to be the case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid sorting of the pubkeys...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes for managing sortedmulti
- by deafult we should try to use sortedmulti, if we fail - then we run a per-address addition.
The changes also batch all requests into a single rpc call.
logic.py
into a file for each of its classes.