-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service class refactoring #1623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for specter-desktop-docs ready! 🔨 Explore the source changes: d64cca0 🔍 Inspect the deploy log: https://app.netlify.com/sites/specter-desktop-docs/deploys/62386389d6ab33000997a147 😎 Browse the preview: https://deploy-preview-1623--specter-desktop-docs.netlify.app/services/services |
moneymanolis
reviewed
Mar 7, 2022
moneymanolis
reviewed
Mar 7, 2022
Co-authored-by: Manolis <70536101+moneymanolis@users.noreply.github.com>
…desktop into service_class_refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to the extension-framework:
ext
which contains all the extensions. This might be a semi-good idea.src/cryptoadvance
, we need a more sophisticated method to detect, whether we're in the specter-desktop repo-folder.Flask-APScheduler
module. A scheduler instance will be created and passed to theafter_serverpy_init_app
callback. The dummyextension has some example code on how to use this.ServiceUnencryptedStorage
class available in order to store service specific stuff unencrypted.