Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service class refactoring #1623

Merged
merged 15 commits into from
Mar 21, 2022
Merged

Conversation

k9ert
Copy link
Contributor

@k9ert k9ert commented Mar 3, 2022

Some changes to the extension-framework:

  • Specter now has a dictionary called ext which contains all the extensions. This might be a semi-good idea.
  • As we now might have external extensions in separate repos and therefore directories like src/cryptoadvance, we need a more sophisticated method to detect, whether we're in the specter-desktop repo-folder.
  • There is now a way to schedule events with the help of the Flask-APScheduler module. A scheduler instance will be created and passed to the after_serverpy_init_app callback. The dummyextension has some example code on how to use this.
  • Now there is also an ServiceUnencryptedStorage class available in order to store service specific stuff unencrypted.
  • Some bugfixes

@netlify
Copy link

netlify bot commented Mar 3, 2022

✅ Deploy Preview for specter-desktop-docs ready!

🔨 Explore the source changes: d64cca0

🔍 Inspect the deploy log: https://app.netlify.com/sites/specter-desktop-docs/deploys/62386389d6ab33000997a147

😎 Browse the preview: https://deploy-preview-1623--specter-desktop-docs.netlify.app/services/services

@k9ert k9ert marked this pull request as draft March 3, 2022 15:21
@moneymanolis
Copy link
Collaborator

Opportunity to change Services to Plugins in this PR
image

@k9ert k9ert marked this pull request as ready for review March 21, 2022 11:12
@k9ert k9ert merged commit 8dd294b into cryptoadvance:master Mar 21, 2022
@k9ert k9ert deleted the service_class_refactoring branch January 27, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants