Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: versionChecker and downloadloc #1633

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Bugfix: versionChecker and downloadloc #1633

merged 1 commit into from
Mar 22, 2022

Conversation

k9ert
Copy link
Collaborator

@k9ert k9ert commented Mar 22, 2022

fixes:

2022-03-21T23:01:38.097Z [info] : stderr-SPECTERD: ERROR in version: name 'self' is not defined
Traceback (most recent call last):
  File "cryptoadvance\specter\util\version.py", line 148, in _get_latest_version_from_github
NameError: name 'self' is not defined
SPECTERD: INFO in version: version checked. upgrade: False

and also fixed downloadlocation.

@netlify
Copy link

netlify bot commented Mar 22, 2022 •
edited
Loading

✅ Deploy Preview for specter-desktop-docs ready!

🔨 Explore the source changes: 1126b6e

🔍 Inspect the deploy log: https://app.netlify.com/sites/specter-desktop-docs/deploys/6239c78363e32400088d0a73

😎 Browse the preview: https://deploy-preview-1633--specter-desktop-docs.netlify.app

moneymanolis
moneymanolis approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@moneymanolis moneymanolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moneymanolis moneymanolis linked an issue Mar 22, 2022 that may be closed by this pull request
NameError: name 'self' is not defined #1628
Closed
@k9ert k9ert merged commit 9caf5f2 into cryptoadvance:master Mar 22, 2022
@k9ert k9ert deleted the bugfixes_for_release branch March 22, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moneymanolis moneymanolis moneymanolis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NameError: name 'self' is not defined
2 participants
@k9ert @moneymanolis