Chore: Refactor_wallet_manager

[k9ert]

This is a preparation of making the WalletManager aware of the active node via a session-attribute.

relates to #1661

[netlify]

✅ Deploy Preview for specter-desktop-docs ready!

Name	Link
🔨 Latest commit	b0f112d
🔍 Latest deploy log	https://app.netlify.com/sites/specter-desktop-docs/deploys/62af2d806a0211000854af49
😎 Deploy Preview	https://deploy-preview-1667--specter-desktop-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[k9ert]

The experimental session-feature used in the spec_multiuser_sessions.js from cypress doesn't seem to work for us. I've created:
cypress-io/cypress#21138

[k9ert]

This is ready for review. I'd like to get this in part by part. I could continue here but i think it's better to merge it as is.

[moneymanolis]

Perhaps I am overlooking sth. but where is the name variable set?

[k9ert]

It's defining a function and the name is the parameter here. It's initialized with the arguments at call time, e.g. in line 39.

[djpnewton]

So this does not yet make the wallet manager session aware? It is just refactoring to use less instance variables such that when the wallet manager is session aware things like the wallets_update_list dict will not contain wallets from multiple different sessions?

[k9ert]

So this does not yet make the wallet manager session aware?
No. It's also not planned to make it session-aware.

It is just refactoring to use less instance variables such that when the wallet manager is
session aware things like the wallets_update_list dict will not contain wallets from multiple different sessions?

This was just a side_effect of that change. The main point from my point of view is that the WalletManager no longer throws away all it's data when the Node gets changed. This is a prerequisite to requesting data from an instance which is session-aware.