Bugfix: wrong arguments for requests_session #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for specter-desktop-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Two things are still missing in this PR:
|
|
Two things are still missing in this PR:
|
|
The second one was mitigated by reasonable error-logging. |
ankur12-1610
pushed a commit
to ankur12-1610/specter-desktop
that referenced
this pull request
May 18, 2022
* fix confused utxorescan * switch arguments * Yet another failure mode * using the param as well * Fix abortion of UTXO rescan * forgotten commit * onion-explorer support
ankur12-1610
pushed a commit
to ankur12-1610/specter-desktop
that referenced
this pull request
Jun 2, 2022
* fix confused utxorescan * switch arguments * Yet another failure mode * using the param as well * Fix abortion of UTXO rescan * forgotten commit * onion-explorer support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You cannot call it with the explorer as argument. Instead, we're now checking within the UtxoScanner for inconsitent arguments.