-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import-export PSBT transactions #175
Import-export PSBT transactions #175
Conversation
Added import of the external PSBTs, updated the description above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it a bit, works great, just needs to make sure if an error arises there should be flashed an error message instead of the error screen (I marked this in comment).
@@ -582,6 +588,12 @@ def wallet_send(wallet_alias): | |||
return render_template("wallet/send/sign/wallet_send_sign_psbt.jinja", psbt=psbt, label=label, | |||
wallet_alias=wallet_alias, wallet=wallet, | |||
specter=app.specter, rand=rand) | |||
elif action == "importpsbt": | |||
b64psbt = request.form["rawpsbt"] | |||
psbt = wallet.importpsbt(b64psbt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add try/ except to catch errors...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated!
This PR makes possible cooperative multisig signing.
Now if multiple people are holding the keys and using their own specters they can share partially signed transactions with each other.
Changes:
The flow then is: