-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate setttings into tabs #176
Separate setttings into tabs #176
Conversation
Nice, much cleaner now! A few comments...
It might make sense to redirect from |
Weird behaviour happens when you choose multiuser mode and instead of saving it you click on the OTP link button. And maybe it's better not to redirect to the main page from the settings any more, not sure... |
Very strange behavior of the controller test suddenly. When the same code is inside a single test it seems to pass, but when they are in 2 tests I get a 404 suddenly, despite each one separately passing. For now, I just added them together into a single test. |
Might be because tests run in random order, so at the end of the test function we need to make sure we are logged in. |
This doesn't seem to help :( The problem is that I just get a |
Since the Settings page has become quite big and will get bigger in the near future, this PR splits it to General, Auth, and Bitcoin Core settings pages, with tabs like we use for the wallet.