Remove local caching #242
Merged
Remove local caching #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All transactions look like unconfirmed now... |
|
I don't see it on my side... Do they also say pending? Or are they saying confirmed but still displayed in unconfirmed color? |
|
All pending... |
|
And generating a new block just to make sure doesn't help I guess? Any idea on how to reproduce or nothing special? |
|
Also transaction history page became much slower... |
|
I made a slight change which should make it a bit faster. For me it's now pretty much the same as before, maybe even slightly better (with the last commit), can you please try with that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is mainly performance improvements and bug fixes.
The current Addresses history feature is nice, but it relies on data that is very hard and network costly to retrieve from Bitcoin Core. Since it is not really in the scope of Specter's architecture to be an indexing server, and since this feature seems to be too problematic without such a server, we decided to remove it, at least until we add support for existing indexing servers like Electrum Server.
Changes:
This should resolve: #238 #239