-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pyinstaller builds #258
Merged
stepansnigirev
merged 14 commits into
cryptoadvance:master
from
stepansnigirev:pyinstaller
Jul 26, 2020
Merged
Pyinstaller builds #258
stepansnigirev
merged 14 commits into
cryptoadvance:master
from
stepansnigirev:pyinstaller
Jul 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue with Tor service creation
ben-kaufman
reviewed
Jul 26, 2020
ben-kaufman
approved these changes
Jul 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! just a small comment on disabling debug mode if Tor is enabled. Also, would be good if you could run the specterd.py
and __main__.py
through flake8
check and fix the warnings, I see it gives a few when I check that.
Works great on macOS 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pyinstaller specs to build
specterd
standalone binary that runs the Specter server.Currently no command line arguments are supported, just bare specter server.
To run: download a binary for your platform, extract and run
specterd
Here are test builds to try:
specterd.osx.zip
specterd.win.zip
specterd.linux.tar.gz