Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the linux-binary-build #396

Merged
merged 6 commits into from
Sep 18, 2020
Merged

Conversation

k9ert
Copy link
Collaborator

@k9ert k9ert commented Sep 17, 2020

this fixes #373

@k9ert
Copy link
Collaborator Author

k9ert commented Sep 17, 2020

This is unfortunately not yet ready to merge.

@k9ert
Copy link
Collaborator Author

k9ert commented Sep 17, 2020

I think this is now ready to merge. I tested ... quite some times. I rebuilt and uploaded the docker-image. If now further comments, i'll merge tomorrow and will build the pre-release. At least the windows and the linux-binaries.

@stepansnigirev
Copy link
Collaborator

Sounds good! And if all goes well on Saturday we make the next release.
Can you check the windows build as well? There might be a change in the icon path in the iss file.

@k9ert k9ert merged commit 24677b5 into cryptoadvance:master Sep 18, 2020
@k9ert k9ert deleted the binary-build branch May 19, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

binary for linux is failing to execute properly
2 participants