Skip to content

Commit

Permalink
add missing ascii chars for bip39
Browse files Browse the repository at this point in the history
  • Loading branch information
@stepansnigirev
stepansnigirev committed Mar 19, 2021
1 parent ec583cb commit 04246ce
Showing 1 changed file with 37 additions and 21 deletions.
58 changes: 37 additions & 21 deletions src/gui/screens/input.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,17 @@

class InputScreen(Screen):
CHARSET = [
"1",
"2",
"3",
"4",
"5",
"6",
"7",
"8",
"9",
"0",
"\n",
"q",
"w",
"e",
Expand Down Expand Up @@ -50,40 +61,45 @@ class InputScreen(Screen):
lv.SYMBOL.OK + " Done",
"",
]
# "\'+,-./:;<=>?[\\]^_`{|}~
CHARSET_EXTRA = [
"1",
"2",
"3",
"4",
"5",
"6",
"7",
"8",
"9",
"0",
"\n",
"aA",
"!",
"@",
"#",
"$",
"_",
"%",
"^",
"&",
"-",
"+",
"*",
"(",
")",
"/",
"\n",
"~",
"<",
">",
"/",
"\\",
"{",
"}",
"[",
"]",
"*",
'"',
"\n",
"aA",
"\"",
"'",
"^",
"_",
"-",
"=",
"+",
"\n",
"`",
":",
";",
"!",
",",
".",
"|",
"?",
"\\",
lv.SYMBOL.LEFT,
"\n",
lv.SYMBOL.LEFT + " Back",
Expand All @@ -107,7 +123,7 @@ def __init__(
self.kb = HintKeyboard(self)
self.kb.set_map(self.CHARSET)
self.kb.set_width(HOR_RES)
self.kb.set_height(VER_RES // 3)
self.kb.set_height(int(VER_RES / 2.5))
self.kb.align(self, lv.ALIGN.IN_BOTTOM_MID, 0, 0)

self.ta = lv.ta(self)
Expand Down

2 comments on commit 04246ce

@bitcoinheiro
Copy link
Contributor

@bitcoinheiro bitcoinheiro commented on 04246ce Mar 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 71 and 90 have same char. I saw this duplicate on device too.
The (space) char place is not well defined and some people might think it's not there.

@stepansnigirev
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Space is in the middle of the bottom line. But you are right, it's not very clear that it's a space. I'll probably add borders for the buttons so they are more separated.

Please sign in to comment.