ask for file overwrite on sd card #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for specter-diy-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| if not platform.is_sd_present(): | ||
| raise KeyStoreError("SD card is not present") | ||
| platform.mount_sdcard() | ||
| platform.sdcard.mount() | ||
|
|
||
| if platform.file_exists(fullpath): |
There was a problem hiding this comment.
@stepansnigirev "File already exists" and "Would you like to overwrite this file?" feels a bit too weak here as a warning for potentially overwriting a seed by accident. Looks to me that we can safely assume that the user is overwriting a seed here with this check: if platform.file_exists(fullpath)
What do you think?
moneymanolis
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #252