Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension-generation needs adjustements #10

Closed
k9ert opened this issue Nov 4, 2022 · 2 comments
Closed

Extension-generation needs adjustements #10

k9ert opened this issue Nov 4, 2022 · 2 comments

Comments

@k9ert
Copy link
Contributor

k9ert commented Nov 4, 2022

The extension-generation process is currently assuming you need encrypted userdata. That should get adjusted like this:

Mind the different templating syntax. Those are "metatemplates" as they are creating templates which themself are later templates.

You can test it via using --tmpl-fs-source and checkout the dummy-project somewhere. Also i've created a small section about https://docs.specter.solutions/desktop/extensions/intro/#virtualenv-management

@k9ert
Copy link
Contributor Author

k9ert commented Nov 4, 2022

One other thing here would be that the templates are becoming more dependent on the version of specter controlling the generation-process. It would be cool if we could get another cli-switch which would specify the version of specter, simply assuming that the dummy-repo has tags with that version (and maybe falling back to master if it doesn't).
This is already established in parts: https://github.com/cryptoadvance/specter-desktop/blob/master/src/cryptoadvance/specter/services/extension_gen.py#L41 but need to be parametrized and maybe the fallback-solution need to be implemented.

@k9ert
Copy link
Contributor Author

k9ert commented Nov 4, 2022

Wrong project. Created here: cryptoadvance/specter-desktop#1957

@k9ert k9ert closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant