Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: No encryption for devhel extension required #1942

Conversation

relativisticelectron
Copy link
Collaborator

In #1918 the encryption of the service data was made optional. This PR removes the requirement user_secret_decrypted_required for the devhelp extension. That way the settings are also accessible without authentication.

@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for specter-desktop-docs canceled.

Name Link
🔨 Latest commit 7d94b92
🔍 Latest deploy log https://app.netlify.com/sites/specter-desktop-docs/deploys/6364f133079423000aeae30d

@k9ert
Copy link
Collaborator

k9ert commented Oct 26, 2022

Would you mind to adjust the extension-generation process as part of this PR? It's not difficult and you would get insights into the extension system:

Mind the different templating syntax. Those are "metatemplates" as they are creating templates which themself are later templates.

You can test it via using --tmpl-fs-source and checkout the dummy-project somewhere. Also i've created a small section about https://docs.specter.solutions/desktop/extensions/intro/#virtualenv-management

@k9ert
Copy link
Collaborator

k9ert commented Oct 26, 2022

One other thing here would be that the templates are becoming more dependent on the version of specter controlling the generation-process. It would be cool if we could get another cli-switch which would specify the version of specter, simply assuming that the dummy-repo has tags with that version (and maybe falling back to master if it doesn't).
This is already established in parts: https://github.com/cryptoadvance/specter-desktop/blob/master/src/cryptoadvance/specter/services/extension_gen.py#L41 but need to be parametrized and maybe the fallback-solution need to be implemented.

@k9ert
Copy link
Collaborator

k9ert commented Nov 4, 2022

Copied the extension-generation wishlist here:
cryptoadvance/spectrum#10

will test and merge soon.

@k9ert k9ert merged commit 1d2fea9 into cryptoadvance:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants